Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review translations DE, FR, RU #91

Open
niqdev opened this issue Dec 30, 2018 · 10 comments
Open

Review translations DE, FR, RU #91

niqdev opened this issue Dec 30, 2018 · 10 comments

Comments

@niqdev
Copy link
Member

niqdev commented Dec 30, 2018

Initially the translations were made by contributors, but in the latest releases all the new labels/descriptions were made using google translator, so they might not be precise, review:

@siva73
Copy link
Contributor

siva73 commented Jan 1, 2019

Hi,

I can translate to Russian.

Regards,
Siva73.

@siva73
Copy link
Contributor

siva73 commented Jan 1, 2019

Пожертвования исключены налог и может варьироваться от одной страны в другую
change to
Пожертвования не включают налоги и могут варьироваться в зависимости от страны

@siva73
Copy link
Contributor

siva73 commented Jan 1, 2019

Неверный адрес IP или домен
change to
Неверный домен или IP адрес

@siva73
Copy link
Contributor

siva73 commented Jan 1, 2019

<string name="donation_coffee_description">Кофе, чтобы держать меня разбудила, когда я программу в течение ночи!</string>
<string name="donation_beer_name">Пиво</string>
<string name="donation_beer_description">Холодное пиво, чтобы увеличить свою производительность!</string>
<string name="donation_pizza_name">Пицца</string>

Пицца, чтобы сделать меня счастливым!

change to

<string name="donation_coffee_description">Кофе, чтобы будить меня, когда я программирую по ночам ;-)</string>
<string name="donation_beer_name">Пиво</string>
<string name="donation_beer_description">Холодное пиво, чтобы увеличить мою производительность :-)</string>
<string name="donation_pizza_name">Пицца</string>

Пицца, для полного счастья!

@niqdev
Copy link
Member Author

niqdev commented Jan 1, 2019

Hi @siva73, thanks for you interest.
Are you a developer? Would you mind to open a PR?

@siva73
Copy link
Contributor

siva73 commented Jan 1, 2019

No, I not developer, I am advanced user))))

@siva73
Copy link
Contributor

siva73 commented Jan 1, 2019

Sorry, I can change string.xml for RU.

@niqdev
Copy link
Member Author

niqdev commented Jan 1, 2019

Thanks, I've already made your changes and I'm going to release it soon. Everything else is ok?

@siva73
Copy link
Contributor

siva73 commented Jan 2, 2019

Hi,

Everything else is ok.
If I find mistake, I write about it at this issue.

Regards,
Siva73.

@niqdev
Copy link
Member Author

niqdev commented Feb 10, 2019

@siva73 could you please review the following files with the latest changes

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants