New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Ctrl-F and right click #7

Open

adrienjoly opened this issue Jan 15, 2017 · 1 comment

Labels

enhancement help wanted

Member

adrienjoly commented Jan 15, 2017

No description provided.

adrienjoly mentioned this issue

Back navigation #8

Closed

adrienjoly added enhancement help wanted labels

adrienjoly changed the title ~~Enhancement: allow Ctrl-F and right click.~~ Enable Ctrl-F and right click

Member Author

adrienjoly commented Aug 26, 2018

The "find" feature is harder to implement than I thought:

I don't know how to inject https://github.com/rhysd/electron-in-page-search into the renderer, as the pages are loaded from openwhyd.org (instead of locally) and I've disabled require() in order to prevent jQuery to run in node.js mode.
Next thing to try: https://www.jqueryscript.net/text/Fast-Live-Search-Plugin-With-Text-Highlighting-Gsearch.html (jquery plugin that I could probably inject using executeJavaScript)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment