[fix] Use device network section for STP on OpenWrt > 21 #123 #126
Conversation
pandafy
force-pushed
the
issues/123-stp
branch
from
93d0ea5 to
3371655
Compare
| txqueuelen = 1000, | ||
| type = "bridge", | ||
| up = true | ||
| } |
There was a problem hiding this comment.
Why is the test expecting stp as true even though is not defined here?
Is the code assuming STP is turned on by default? That is not the case https://openwrt.org/docs/guide-user/base-system/basic-networking.
There was a problem hiding this comment.
I was following the existing code here. I will update the test to check for multiple scenarios.
openwrt-openwisp-monitoring/openwisp-monitoring/tests/main_env.lua
Lines 22 to 23 in 0f829f8
There was a problem hiding this comment.
ubus:call('network.interface', 'dump', {}) command does not return the STP status.
It is fetched by another call uci_cursor.get('network', interface['interface'], 'stp') on OpenWrr < 21.
On OpenWrt >= 21, we loop over all the device sections and get the STP value for the bridge
Fixes #123