git: build fails with LTO enabled #24366

Ra2-IFV · 2024-06-10T14:01:08Z

Issue template (remove lines from top till here)

Maintainer: @neheb
Environment: aarch64 generic 2b01007

Description:
Enabling LTO for git will cause build to fail, the error log is here

/openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.1.0_musl/include/stdio.h: In function 'process_curl_messages':
/openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.1.0_musl/include/stdio.h:90:8: error: inlining failed in call to 'always_inline' 'fwrite': function body can be overwritten at link time
   90 | size_t fwrite(const void *__restrict, size_t, size_t, FILE *__restrict);
      |        ^
http.c:355:33: note: called from here
  355 |                                 fprintf(stderr, "Received DONE message for unknown request!\n");
      |                                 ^
In function 'fetch_using_walker',
    inlined from 'cmd_main' at http-fetch.c:167:9:
/openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.1.0_musl/include/stdio.h:90:8: error: inlining failed in call to 'always_inline' 'fwrite': function body can be overwritten at link time
   90 | size_t fwrite(const void *__restrict, size_t, size_t, FILE *__restrict);
      |        ^
http-fetch.c:39:17: note: called from here
   39 |                 fprintf(stderr,
      |                 ^
make[4]: *** [/openwrt/tmp/cc7XwYlE.mk:2: /openwrt/tmp/ccvHfD60.ltrans0.ltrans.o] Error 1
make[4]: *** Waiting for unfinished jobs....
In function 'create_ref_symlink',
    inlined from 'create_symref_locked' at refs/files-backend.c:1927:30,
    inlined from 'files_create_symref' at refs/files-backend.c:1963:8:
/openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.1.0_musl/include/stdio.h:90:8: error: inlining failed in call to 'always_inline' 'fwrite': function body can be overwritten at link time
   90 | size_t fwrite(const void *__restrict, size_t, size_t, FILE *__restrict);
      |        ^
refs/files-backend.c:1901:17: note: called from here
 1901 |                 fprintf(stderr, "no symlink - falling back to symbolic ref\n");
      |                 ^
make[4]: *** [/openwrt/tmp/cc7XwYlE.mk:23: /openwrt/tmp/ccvHfD60.ltrans7.ltrans.o] Error 1
lto-wrapper: fatal error: make returned 2 exit status
compilation terminated.
mold: fatal: lto-wrapper failed

The text was updated successfully, but these errors were encountered:

brada4 · 2024-06-11T11:41:26Z

Could you share diffconfig?

Ra2-IFV · 2024-06-11T22:11:30Z

What should I compare my config with?

Ra2-IFV · 2024-06-14T00:21:56Z

it should has nothing to do with custom config file. just LTO problems.
My suggestion is simply append no-lto to BUILD_PKG_FLAGS in Makefile as a workaround, since it's not important at all, and it may take developers a long time to make git compatible with LTO.

brada4 · 2024-06-14T05:58:52Z

Default is gcc13, it is imperative that you show diffconfig that leads to error, or alternatively submit a PR.

Ra2-IFV · 2024-06-14T14:13:36Z

yeah, I'm using GCC14 for testing purpose, enabled -O3 and LTO in make menuconfig
~~So may I ask, how to run diffconfig? It's not a standard command.~~ It's in the scripts dir, sorry
GCC13, LTO enabled, diffconfig ouput:

CONFIG_TARGET_rockchip=y
CONFIG_TARGET_rockchip_armv8=y
CONFIG_TARGET_rockchip_armv8_DEVICE_friendlyarm_nanopi-r4s=y
CONFIG_DEVEL=y
CONFIG_TOOLCHAINOPTS=y
CONFIG_EXTRA_OPTIMIZATION="-Ofast -fno-caller-saves -fno-plt -pipe"
# CONFIG_GDB is not set
CONFIG_LIBCURL_COOKIES=y
CONFIG_LIBCURL_FILE=y
CONFIG_LIBCURL_FTP=y
CONFIG_LIBCURL_HTTP=y
CONFIG_LIBCURL_MBEDTLS=y
CONFIG_LIBCURL_NGHTTP2=y
CONFIG_LIBCURL_NO_SMB="!"
CONFIG_LIBCURL_PROXY=y
CONFIG_LIBCURL_UNIX_SOCKETS=y
CONFIG_OPENSSL_ENGINE=y
CONFIG_OPENSSL_WITH_ASM=y
CONFIG_OPENSSL_WITH_CHACHA_POLY1305=y
CONFIG_OPENSSL_WITH_CMS=y
CONFIG_OPENSSL_WITH_DEPRECATED=y
CONFIG_OPENSSL_WITH_ERROR_MESSAGES=y
CONFIG_OPENSSL_WITH_IDEA=y
CONFIG_OPENSSL_WITH_MDC2=y
CONFIG_OPENSSL_WITH_PSK=y
CONFIG_OPENSSL_WITH_SEED=y
CONFIG_OPENSSL_WITH_SRP=y
CONFIG_OPENSSL_WITH_TLS13=y
CONFIG_OPENSSL_WITH_WHIRLPOOL=y
CONFIG_PACKAGE_git=m
CONFIG_PACKAGE_git-http=m
CONFIG_PACKAGE_libcurl=m
CONFIG_PACKAGE_libnghttp2=m
CONFIG_PACKAGE_libopenssl=m
CONFIG_PACKAGE_zlib=m
CONFIG_TARGET_OPTIMIZATION="-Os -pipe -march=armv8-a -mtune=cortex-a72.cortex-a53"
CONFIG_TARGET_OPTIONS=y
# CONFIG_TARGET_ROOTFS_EXT4FS is not set
CONFIG_USE_GC_SECTIONS=y
CONFIG_USE_LTO=y
CONFIG_USE_MOLD=y

make package/feeds/packages/git/{clean,prepare,compile} -j1 V=s output: git.log

brada4 · 2024-06-14T14:19:00Z

/openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.1.0_musl/include/stdio.h

Yeah, gcc13, maybe even gcc12....

Ra2-IFV · 2024-06-14T16:44:30Z

~~wtf I did ran make dirclean before...~~

/home/debian/openwrt/staging_dir/toolchain-aarch64_generic_gcc-13.3.0_musl/include/stdio.h: In function 'process_curl_messages':
/home/debian/openwrt/staging_dir/toolchain-aarch64_generic_gcc-13.3.0_musl/include/stdio.h:90:8: error: inlining failed in call to 'always_inline' 'fwrite': function body can be overwritten at link time

oh I did it right. Still complaining errors on GCC13.

or alternatively submit a PR.

I don't know if submiting a workaround PR would be accepted.

brada4 · 2024-06-14T19:31:48Z

Make coinciding error and diffconfig. Without -ofast which is guaranteed to miscompile

Ra2-IFV · 2024-06-15T03:14:37Z

diffconfig:

CONFIG_TARGET_rockchip=y
CONFIG_TARGET_rockchip_armv8=y
CONFIG_TARGET_rockchip_armv8_DEVICE_friendlyarm_nanopi-r4s=y
CONFIG_DEVEL=y
CONFIG_TOOLCHAINOPTS=y
CONFIG_EXTRA_OPTIMIZATION="-fno-caller-saves -fno-plt -pipe"
# CONFIG_GDB is not set
CONFIG_LIBCURL_COOKIES=y
CONFIG_LIBCURL_FILE=y
CONFIG_LIBCURL_FTP=y
CONFIG_LIBCURL_HTTP=y
CONFIG_LIBCURL_MBEDTLS=y
CONFIG_LIBCURL_NGHTTP2=y
CONFIG_LIBCURL_NO_SMB="!"
CONFIG_LIBCURL_PROXY=y
CONFIG_LIBCURL_UNIX_SOCKETS=y
CONFIG_OPENSSL_ENGINE=y
CONFIG_OPENSSL_WITH_ASM=y
CONFIG_OPENSSL_WITH_CHACHA_POLY1305=y
CONFIG_OPENSSL_WITH_CMS=y
CONFIG_OPENSSL_WITH_DEPRECATED=y
CONFIG_OPENSSL_WITH_ERROR_MESSAGES=y
CONFIG_OPENSSL_WITH_IDEA=y
CONFIG_OPENSSL_WITH_MDC2=y
CONFIG_OPENSSL_WITH_PSK=y
CONFIG_OPENSSL_WITH_SEED=y
CONFIG_OPENSSL_WITH_SRP=y
CONFIG_OPENSSL_WITH_TLS13=y
CONFIG_OPENSSL_WITH_WHIRLPOOL=y
CONFIG_PACKAGE_git=m
CONFIG_PACKAGE_git-http=m
CONFIG_PACKAGE_libcurl=m
CONFIG_PACKAGE_libnghttp2=m
CONFIG_PACKAGE_libopenssl=m
CONFIG_PACKAGE_zlib=m
CONFIG_TARGET_OPTIMIZATION="-pipe -march=armv8-a -mtune=cortex-a72.cortex-a53 -O3"
CONFIG_TARGET_OPTIONS=y
# CONFIG_TARGET_ROOTFS_EXT4FS is not set
CONFIG_USE_GC_SECTIONS=y
CONFIG_USE_LTO=y
CONFIG_USE_MOLD=y

build log: git.log

Must both use (-O3 or -Ofast) and LTO to reproduce this error. Test passed with -O2.

Ra2-IFV · 2024-06-15T03:14:58Z

Close this issue?

brada4 · 2024-06-15T07:56:22Z

Yep, O3/Ofast is excessive optimization . Like 1.0*(2+3)/4 can evaluate in any order ignoring parens

Git doen't support lto with gcc flag -O3 and -Ofast. This is discussed in openwrt#24366. If CONFIG_USE_LTO=y, filter -O% from CPPFLAGS and set to -O2. Signed-off-by: Ryan Keane <[email protected]>

Ra2-IFV · 2024-11-13T06:01:02Z

New update on this:
This is a reproducible bug, reported in this mailing list https://lore.kernel.org/git/CAHfWF5mjquES-nocQaK+CAEsqWgdy-_OYdGtN82heYs0eJP3eQ@mail.gmail.com/T/#t
And I was wrong, it's caused by fortify headers.

If has FORTIFY_SOURCE=y and CONFIG_USE_LTO=y in build config, git will fail to compile with the following example error: /openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.1.0_musl/include/stdio.h: In function 'process_curl_messages': /openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.1.0_musl/include/stdio.h:90:8: error: inlining failed in call to 'always_inline' 'fwrite': function body can be overwritten at link time 90 | size_t fwrite(const void *__restrict, size_t, size_t, FILE *__restrict); | ^ http.c:355:33: note: called from here 355 | fprintf(stderr, "Received DONE message for unknown request!\n"); | ^ A related issue is openwrt#13016 . This commit set PKG_FORTIFY_SOURCE to 0 if CONFIG_USE_LTO is y. Close: openwrt#24366 Link: https://lore.kernel.org/git/CAHfWF5mjquES-nocQaK+CAEsqWgdy-_OYdGtN82heYs0eJP3eQ@mail.gmail.com/T/#t Link: openwrt/openwrt#13016 Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110834 Signed-off-by: Ryan Keane <[email protected]>

If PKG_FORTIFY_SOURCE is not 0 and lto is enabled for package git, git will fail to compile with the following example error: /openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.1.0_musl/include/stdio.h: In function 'process_curl_messages': /openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.1.0_musl/include/stdio.h:90:8: error: inlining failed in call to 'always_inline' 'fwrite': function body can be overwritten at link time 90 | size_t fwrite(const void *__restrict, size_t, size_t, FILE *__restrict); | ^ http.c:355:33: note: called from here 355 | fprintf(stderr, "Received DONE message for unknown request!\n"); | ^ A related issue is openwrt#13016 . This commit set PKG_FORTIFY_SOURCE to 0 if CONFIG_USE_LTO is y. Close: openwrt#24366 Link: https://lore.kernel.org/git/CAHfWF5mjquES-nocQaK+CAEsqWgdy-_OYdGtN82heYs0eJP3eQ@mail.gmail.com/T/#t Link: openwrt/openwrt#13016 Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110834 Signed-off-by: Ryan Keane <[email protected]>

If PKG_FORTIFY_SOURCE is not 0 and lto is enabled for package git, it will fail to compile with the following example error: /openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.1.0_musl/include/stdio.h: In function 'process_curl_messages': /openwrt/staging_dir/toolchain-aarch64_generic_gcc-14.1.0_musl/include/stdio.h:90:8: error: inlining failed in call to 'always_inline' 'fwrite': function body can be overwritten at link time 90 | size_t fwrite(const void *__restrict, size_t, size_t, FILE *__restrict); | ^ http.c:355:33: note: called from here 355 | fprintf(stderr, "Received DONE message for unknown request!\n"); | ^ A related issue is openwrt#13016 . This commit set PKG_FORTIFY_SOURCE to 0 if CONFIG_USE_LTO is y. Close openwrt#24366 Link: https://lore.kernel.org/git/CAHfWF5mjquES-nocQaK+CAEsqWgdy-_OYdGtN82heYs0eJP3eQ@mail.gmail.com/T/#t Link: openwrt/openwrt#13016 Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110834 Signed-off-by: Ryan Keane <[email protected]>

Ra2-IFV closed this as completed Jun 18, 2024

Ra2-IFV mentioned this issue Jun 27, 2024

git: Force use -O2 when lto enabled #24470

Closed

Ra2-IFV reopened this Nov 13, 2024

Ra2-IFV linked a pull request Nov 13, 2024 that will close this issue

git: Set PKG_FORTIFY_SOURCE to 0 when lto enabled #25334

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

git: build fails with LTO enabled #24366

git: build fails with LTO enabled #24366

Ra2-IFV commented Jun 10, 2024

brada4 commented Jun 11, 2024

Ra2-IFV commented Jun 11, 2024

Ra2-IFV commented Jun 14, 2024

brada4 commented Jun 14, 2024

Ra2-IFV commented Jun 14, 2024

brada4 commented Jun 14, 2024

Ra2-IFV commented Jun 14, 2024 •

edited

Loading

brada4 commented Jun 14, 2024

Ra2-IFV commented Jun 15, 2024

Ra2-IFV commented Jun 15, 2024

brada4 commented Jun 15, 2024

Ra2-IFV commented Nov 13, 2024

git: build fails with LTO enabled #24366

git: build fails with LTO enabled #24366

Comments

Ra2-IFV commented Jun 10, 2024

Issue template (remove lines from top till here)

brada4 commented Jun 11, 2024

Ra2-IFV commented Jun 11, 2024

Ra2-IFV commented Jun 14, 2024

brada4 commented Jun 14, 2024

Ra2-IFV commented Jun 14, 2024

brada4 commented Jun 14, 2024

Ra2-IFV commented Jun 14, 2024 • edited Loading

brada4 commented Jun 14, 2024

Ra2-IFV commented Jun 15, 2024

Ra2-IFV commented Jun 15, 2024

brada4 commented Jun 15, 2024

Ra2-IFV commented Nov 13, 2024

Ra2-IFV commented Jun 14, 2024 •

edited

Loading