Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit correspondence between the spec and VHLO #1155

Closed
burmako opened this issue Feb 11, 2023 · 2 comments
Closed

Audit correspondence between the spec and VHLO #1155

burmako opened this issue Feb 11, 2023 · 2 comments
Assignees

Comments

@burmako
Copy link
Contributor

burmako commented Feb 11, 2023

Before we start providing compatibility guarantees for VHLO, it sounds like a good idea to go through all ops in the spec and see where the correspondence between the spec and VHLO is not 1:1. All these cases should be documented in Frontend Contract tickets.

@burmako burmako self-assigned this Feb 11, 2023
@burmako
Copy link
Contributor Author

burmako commented Feb 19, 2023

Documenting the current progress of the audit:

1) Attributes: #1188, #1190, #1191, #1192, #1194 and #1195 - these pull requests have made significant progress with aligning VHLO attributes with the StableHLO spec. Remaining work:

2) Types: #1189 makes some refactorings to align VHLO types with the StableHLO spec. Remaining work:

3) Operations: #1184 streamlines VhloOps.td, ordering the ops alphabetically to simplify comparison with the StableHLO spec. Based on this work, I should be able to complete the audit shortly.

@burmako
Copy link
Contributor Author

burmako commented Feb 19, 2023

#1184 completes the audit of the correspondence between the spec and VHLO. Remaining work:

Overall, the audit confirms that we are almost ready for StableHLO v0.9 (no unexpected issues that could become a blocker), and that the plan for StableHLO v1.0 makes sense (all todos except one - #1187 - introduced during the audit are known issues which are part of the Frontend Contract workstream).

Next steps: there are two time-sensitive questions about the VHLO opset to resolve before releasing StableHLO v0.9: #1056 and #1183. Both of these tickets affect a large area of VHLO, so it would be very good to fit them in while we still don't provide any compatibility guarantees for VHLO.

There is another ticket with a huge blast radius - #351 - but we will need quite a bit of time to form a plan of action for this one and to prepare our users, so fitting it into the v0.9 timeframe will be infeasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant