Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve configuration of concurrent daemon pod updater workers (#1907) #1919

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

huangchenzhao
Copy link
Member

What type of PR is this?

/kind good-first-issue
/kind feature

What this PR does / why we need it:

improve the configuration of concurrent daemonpodupdater worker in yurt-manager component

Which issue(s) this PR fixes:

Fixes #1907

Copy link

sonarcloud bot commented Jan 14, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ab41ea6) 52.18% compared to head (81d4b47) 52.17%.
Report is 1 commits behind head on master.

Files Patch % Lines
.../daemonpodupdater/daemon_pod_updater_controller.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1919      +/-   ##
==========================================
- Coverage   52.18%   52.17%   -0.01%     
==========================================
  Files         172      172              
  Lines       20880    20878       -2     
==========================================
- Hits        10896    10894       -2     
  Misses       9017     9017              
  Partials      967      967              
Flag Coverage Δ
unittests 52.17% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Jan 15, 2024
@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch merged commit a6b0442 into openyurtio:master Jan 15, 2024
12 of 13 checks passed
@rambohe-ch
Copy link
Member

@huangchenzhao welcome you to apply the OpenYurt community member, you can post an issue in openyurtio/community repo and set me as sponsor. here is an example: openyurtio/community#77

@huangchenzhao
Copy link
Member Author

@huangchenzhao welcome you to apply the OpenYurt community member, you can post an issue in openyurtio/community repo and set me as sponsor. here is an example: openyurtio/community#77

Thanks for the opportunity to become a member of openyurt! It is my honor to join the openyurt community to focus on more solid work. I will follow the link to apply for that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]improve configuration of concurrent daemon pod updater workers
2 participants