Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support configmap delete #791

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

huiwq1990
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Apr 6, 2022
@openyurt-bot openyurt-bot requested review from DrmagicE and qclc April 6, 2022 12:24
@openyurt-bot openyurt-bot added the size/S size/S 10-29 label Apr 6, 2022
@rambohe-ch
Copy link
Member

@huiwq1990 Very appreciate for making pull request. end user should not delete yurt-hub-cfg configmap because yurthub component on edge nodes may not work. if yurt-hub-cfg configmap is deleted accidentally, the feature of yurthub can not be guaranteed. so configmap delete event is not handled.

@rambohe-ch
Copy link
Member

@huiwq1990 Very appreciate for making pull request. end user should not delete yurt-hub-cfg configmap because yurthub component on edge nodes may not work. if yurt-hub-cfg configmap is deleted accidentally, the feature of yurthub can not be guaranteed. so configmap delete event is not handled.

@huiwq1990 I'd like to add a new comment to reply. I think that maybe handle configmap delete event maybe is reasonable, because end user will find feature can not work after delete yurt-hub-cfg configmap. In the current process, even if yurt-hub-cfg configmap is deleted, the original setting feature still can work, it's not reasonable.

@rambohe-ch
Copy link
Member

@huiwq1990 how about add configmap delete event handler for approver, you can dive into the code here:
https://github.com/openyurtio/openyurt/blob/master/pkg/yurthub/filter/approver.go#L73-L76

@rambohe-ch
Copy link
Member

@huiwq1990 welcome you to apply OpenYurt community member. and the apply example is here: openyurtio/community#33

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huiwq1990, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit 3c0e94d into openyurtio:master Apr 8, 2022
@huiwq1990 huiwq1990 deleted the feat-cacheagents branch April 8, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/S size/S 10-29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants