Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 cached image are never used #2138

Open
benoit74 opened this issue Jan 27, 2025 · 0 comments · May be fixed by #2143
Open

S3 cached image are never used #2138

benoit74 opened this issue Jan 27, 2025 · 0 comments · May be fixed by #2143
Assignees
@benoit74
Labels
bug regression First as tragedy, then as farce ;-)
Milestone
1.14.1

Comments

@benoit74
Copy link
Contributor

While debugging #2136, I realized that we do not use the S3 cached image anymore.

We download the S3 image but finally always end-up download the upstream version and re-encoding it.

Looks like a regression induced by #2062 which does not pass anymore headers except the new Referer header.
@benoit74 benoit74 added bug regression First as tragedy, then as farce ;-) labels Jan 27, 2025
@benoit74 benoit74 added this to the 1.14.1 milestone Jan 27, 2025
@benoit74 benoit74 self-assigned this Jan 27, 2025
@benoit74 benoit74 linked a pull request Jan 28, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoit74 benoit74

Labels
bug regression First as tragedy, then as farce ;-)
Projects
None yet
Milestone
1.14.1
Development

Successfully merging a pull request may close this issue.

Revisit handling of images processing and other fixes openzim/mwoffliner
1 participant
@benoit74