Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls to third party code not respecting type hints #228

Open
rgaudin opened this issue Dec 17, 2024 · 0 comments
Open

Calls to third party code not respecting type hints #228

rgaudin opened this issue Dec 17, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@rgaudin
Copy link
Member

rgaudin commented Dec 17, 2024

Following #227, scraperlib users are not allowed to send values of unexpected types to our API.
We should apply the same strict treatment to our usage of other's APIs.

beartype allows setting this in our code and raising or warning on incorrect calls. Once we fix the codebase, we would keep it and it would serve as automated test for this.

@rgaudin rgaudin added the bug Something isn't working label Dec 17, 2024
@benoit74 benoit74 added this to the backlog milestone Dec 18, 2024
@benoit74 benoit74 modified the milestones: backlog, 6.0.0 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants