Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split desktop and web components #21

Open
2 of 5 tasks
jacobtomlinson opened this issue Nov 28, 2018 · 4 comments
Open
2 of 5 tasks

Split desktop and web components #21

jacobtomlinson opened this issue Nov 28, 2018 · 4 comments

Comments

@jacobtomlinson
Copy link
Member

jacobtomlinson commented Nov 28, 2018

It would be good to pull the bulk of this application out into a separate repository called opsdroid-web. This would contain the react web application which is used for chatting with opsdroid.

This repository would then use opsdroid-web as a dependency and simply wrap it in electron for use as a desktop application.

We could then also use opsdroid-web as a dependency in opsdroid and serve the same interface from the opsdroid web server.

Steps:

  • Create a new repo and move the React application into it
  • Remove/make optional the electron specific code like electron-settings and electron-connect.
  • Create NPM and PyPI packages for the compiled React application (so we can keep Babel out of this project).
  • Update this repo to use the new web package.
  • Update opsdroid to use the new web package.
@FabioRosado
Copy link
Member

I've started working on this, not sure how far I will get haha

@jacobtomlinson
Copy link
Member Author

It looks like the websocket library we are using is node only. So we need to swap it over.

@jacobtomlinson
Copy link
Member Author

I've just pushed up opsdroid-web which is a browser based fork of this project. I've updated the tick boxes above to reflect progress!

@sesam
Copy link

sesam commented Oct 2, 2019

Hi @jacobtomlinson are you available to review PRs for https://github.com/opsdroid/opsdroid-web ? There are some automatic pulls and version updates, and I think they could be squashed into one, tested and then you get one instead of many PRs. Sounds good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants