bug: webhook not called for branch create/delete/rebase/merge events

[wvandeun]

Component

API Server / GraphQL

Infrahub version

1.0.9 and below

Current Behavior

When you create, delete, rebase or merge a branch in Infrahub, the external webhook receiver is not called.

Expected Behavior

The webhook receiver is called when a branch is created, deleted, rebased or merged.

Steps to Reproduce

• start a webhook receiver (a simple flask example)

from flask import Flask, jsonify, request
from pprint import pprint as pp

app = Flask(__name__)


@app.route("/", defaults={"path": ""}, methods=["POST"])
@app.route("/<path:path>", methods=["POST"])
def catch_all(path):
    print("Received a POST request on /" + path)
    data = request.get_json()
    print("Data Received:")
    pp(data)
    return jsonify({"status": "success", "message": "POST request received"}), 200


if __name__ == "__main__":
    app.run(debug=False, port=8200)

• spin up instance of Infrahub
• set up the webhook receiver in Infrahub
• create/delete/rebase or merge a branch

Additional Information

No response

[ogenstad]

I wouldn't classify this as a bug it's the expected behaviour with the existing code. The webhooks only fire on node mutated events. Instead of having this as a bug it should be a feature request and I don't think it's something that should happen automatically instead we should look at redesigning the webhooks completely and allow users to select the type of events that would trigger webhooks to be sent. It could also be branch aware so that we only trigger some event types on the default branch alternatively non-default branches. Also we might want things like filtering to only send webhooks for certain types of nodes within a given namespace etc. There are other event types that could be considered as missing as well such as when a proposed change is opened / merged.