Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for comments in whitelist file #162

Open
orlando-jamie opened this issue Dec 18, 2019 · 1 comment
Open

Allow for comments in whitelist file #162

orlando-jamie opened this issue Dec 18, 2019 · 1 comment

Comments

@orlando-jamie
Copy link

orlando-jamie commented Dec 18, 2019

Hello,
To appease auditor types, it would be useful to allow for comments in the whitelist.yaml file. This will allow us to version control our whitelist file, but also give some human reason for performing the whitelist. As we know, people and knowledge are lost over time, so would be nice to be able to put this information right into the whitelist file.

Suggested behavior

general:
  - RHSA-2018:1345: This finding represents a collection of kernel vulnerabilities. In the container world, containers share the same kernel as the host operating system, and thus, kernel vulnerabilities can not accurately be detected at the container layer. Accurate scans for this vulnerability need to occur on the docker host itself. 
images:
  centos:
    - RHSA-2017:2479: This finding represents vulnerabilities to the basic auth function of httpd. Since we do not use basic auth in applications using the centos container, this finding is not relevant. 
    - RHSA-2018:0805: blah
  alpine:
    - CVE-2017-9671: you get the point
  fluent/fluent-bit:
    - CVE-2017-14062: more
    - CVE-2018-6485: comments
@orlando-jamie
Copy link
Author

Sorry, I am a moron. I did not realize you could just comment with a #. I can achieve what I want with the following.

general:
  # This finding represents a collection of kernel vulnerabilities. In the container world, containers share the same kernel as the host operating system, and thus, kernel vulnerabilities can not accurately be detected at the container layer. Accurate scans for this vulnerability need to occur on the docker host itself. 
  - RHSA-2018:1345
images:
  centos:
    # This finding represents vulnerabilities to the basic auth function of httpd. Since we do not use basic auth in applications using the centos container, this finding is not relevant. 
    - RHSA-2017:2479 
    # blah
    - RHSA-2018:0805
  alpine:
    # you get the point
    - CVE-2017-9671
  fluent/fluent-bit:
    # more
    - CVE-2017-14062
    # comments
    - CVE-2018-6485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant