From 5af347836cd13bc20e5da27a1c69359972f39526 Mon Sep 17 00:00:00 2001 From: nabenabe0928 Date: Wed, 13 Mar 2024 09:06:08 +0100 Subject: [PATCH 1/6] Add version constraint to dask for CI --- .github/workflows/dask_ml.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/dask_ml.yml b/.github/workflows/dask_ml.yml index 3af6a110..f780d7f2 100644 --- a/.github/workflows/dask_ml.yml +++ b/.github/workflows/dask_ml.yml @@ -29,6 +29,8 @@ jobs: pip install git+https://github.com/optuna/optuna.git python -c 'import optuna' + # TODO(nabenabe0928): Remove this constraint once it is fine. + pip install "dask[dataframe]<3.0" pip install -r dask_ml/requirements.txt - name: Run examples run: | From 9df6afa74f62c71d4aec2edf0b2d9fb4c9a8c739 Mon Sep 17 00:00:00 2001 From: nabenabe0928 Date: Wed, 13 Mar 2024 09:08:29 +0100 Subject: [PATCH 2/6] Add version constraint to tensorflow for CI --- .github/workflows/tensorflow.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/tensorflow.yml b/.github/workflows/tensorflow.yml index d6977d57..56b312ce 100644 --- a/.github/workflows/tensorflow.yml +++ b/.github/workflows/tensorflow.yml @@ -31,6 +31,8 @@ jobs: pip install git+https://github.com/optuna/optuna-integration.git python -c 'import optuna_integration' + # TODO(nabenabe0928): Remove this constraint once it is fine. + pip install "tensorflow<2.16.1" pip install -r tensorflow/requirements.txt - name: Run examples run: | From 04fd638168e3153c211efcf14af4f8fdcb97b465 Mon Sep 17 00:00:00 2001 From: nabenabe0928 Date: Wed, 13 Mar 2024 09:44:46 +0100 Subject: [PATCH 3/6] Fix the latest version constraint of dask --- .github/workflows/dask_ml.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dask_ml.yml b/.github/workflows/dask_ml.yml index f780d7f2..357459bc 100644 --- a/.github/workflows/dask_ml.yml +++ b/.github/workflows/dask_ml.yml @@ -30,7 +30,7 @@ jobs: python -c 'import optuna' # TODO(nabenabe0928): Remove this constraint once it is fine. - pip install "dask[dataframe]<3.0" + pip install "dask[dataframe]<2024.3.0" pip install -r dask_ml/requirements.txt - name: Run examples run: | From b9d103352d68e862d367dea73cb7a244dcd1b2a4 Mon Sep 17 00:00:00 2001 From: nabenabe0928 Date: Wed, 13 Mar 2024 12:28:42 +0100 Subject: [PATCH 4/6] Enhance the inline comment --- .github/workflows/dask_ml.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/dask_ml.yml b/.github/workflows/dask_ml.yml index 357459bc..ff166879 100644 --- a/.github/workflows/dask_ml.yml +++ b/.github/workflows/dask_ml.yml @@ -29,7 +29,9 @@ jobs: pip install git+https://github.com/optuna/optuna.git python -c 'import optuna' - # TODO(nabenabe0928): Remove this constraint once it is fine. + # TODO(nabenabe0928/2024/03/12): Remove this version constraint once the following PR is merged. + # https://github.com/dask/distributed/pull/8575 + # NOTE(nabenabe0928): dask-expr supports only python>=3.9. pip install "dask[dataframe]<2024.3.0" pip install -r dask_ml/requirements.txt - name: Run examples From bfe0ecc1b20f29e3c877c6499845406ac9875195 Mon Sep 17 00:00:00 2001 From: nabenabe0928 Date: Wed, 13 Mar 2024 12:30:24 +0100 Subject: [PATCH 5/6] Enhance the inline comment --- .github/workflows/tensorflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tensorflow.yml b/.github/workflows/tensorflow.yml index 56b312ce..7fc65dc7 100644 --- a/.github/workflows/tensorflow.yml +++ b/.github/workflows/tensorflow.yml @@ -31,7 +31,7 @@ jobs: pip install git+https://github.com/optuna/optuna-integration.git python -c 'import optuna_integration' - # TODO(nabenabe0928): Remove this constraint once it is fine. + # NOTE(nabenabe0928): Got "AttributeError: module 'tensorflow' has no attribute 'estimator'". pip install "tensorflow<2.16.1" pip install -r tensorflow/requirements.txt - name: Run examples From cde18133eddaeb89dc3ba5c9decba6bfd1fdfe63 Mon Sep 17 00:00:00 2001 From: nabenabe0928 Date: Thu, 14 Mar 2024 04:18:57 +0100 Subject: [PATCH 6/6] Add a remove comment to tensorflow workflow --- .github/workflows/tensorflow.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/tensorflow.yml b/.github/workflows/tensorflow.yml index 7fc65dc7..d3bb0c52 100644 --- a/.github/workflows/tensorflow.yml +++ b/.github/workflows/tensorflow.yml @@ -32,6 +32,7 @@ jobs: python -c 'import optuna_integration' # NOTE(nabenabe0928): Got "AttributeError: module 'tensorflow' has no attribute 'estimator'". + # TODO(nabenabe0928): Remove this version constraint. pip install "tensorflow<2.16.1" pip install -r tensorflow/requirements.txt - name: Run examples