Skip to content

Commit 7f0f188

Browse files
authored
Merge pull request #4 from oracle-samples/rigebha/mention-pr
include reference to PR to explain temp files
2 parents d2fa7f1 + 71288f2 commit 7f0f188

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

server/server.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,8 @@ def run_oci_command(
195195
config = generate_config(upst, PRIVATE_KEY, "us-sanjose-1")
196196

197197
# write security token to a file
198+
# using temporary files until
199+
# https://github.com/oracle/oci-cli/pull/993
198200
with tempfile.NamedTemporaryFile(mode="wb") as temp_file:
199201
with tempfile.NamedTemporaryFile(mode="wb") as key_temp_file:
200202
temp_file.write(upst.encode("utf-8"))
@@ -214,6 +216,7 @@ def run_oci_command(
214216
"OCI_CLI_FINGERPRINT": config["fingerprint"],
215217
"OCI_CLI_AUTH": "security_token",
216218
# this won't work without an update to oci-cli
219+
# see: https://github.com/oracle/oci-cli/pull/993
217220
# "OCI_CLI_KEY_CONTENT": config["key_content"],
218221
"OCI_CLI_KEY_FILE": key_temp_file.name,
219222
"OCI_CLI_SECURITY_TOKEN_FILE": temp_file.name,

0 commit comments

Comments
 (0)