Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudinit script changes not applied to node pool #944

Closed
nicolas-laduguie opened this issue Aug 14, 2024 · 1 comment · Fixed by #951
Closed

Cloudinit script changes not applied to node pool #944

nicolas-laduguie opened this issue Aug 14, 2024 · 1 comment · Fixed by #951
Labels
bug Something isn't working

Comments

@nicolas-laduguie
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version

Terraform v1.6.6
on darwin_arm64

  • provider registry.terraform.io/hashicorp/cloudinit v2.3.4
  • provider registry.terraform.io/oracle/oci v6.7.0

Affected Resource(s)

modules/workers

Expected Behavior

When creating node pools with modules/workers, and managing cloudinit with "cloud_init" input variable, any further changes applied to cloudinit should be automatically applied to node pool and newly created nodes should inherit from the latest cloudinit changes.

Actual Behavior

Newly created nodes after applying changes on cloudinit do not inherit from those changes.

Steps to Reproduce

  1. setup node pool with cloudinit configured
  2. create node on that pool
  3. change cloudinit and apply changes
  4. drop the old node and create new one
    => the new node would not get latest cloudinit changes.

References

#877

@nicolas-laduguie nicolas-laduguie added the bug Something isn't working label Aug 14, 2024
@nicolas-laduguie
Copy link
Author

nicolas-laduguie commented Aug 14, 2024

Seems linked to this ignore_changes config : https://github.com/oracle-terraform-modules/terraform-oci-oke/blob/46ec5f4f8464b209f1248bcbacf89f342c269d8f/modules/workers/nodepools.tf#L277C1-L278C1
Tested removing this line, applied the changes, and it worked like a charm:

Changes to Outputs:
  ~ worker_pools                   = {
      ~ test= {
            id                               = "ocid1.nodepool.oc1.xxx"
            name                             = "test"
          ~ node_metadata                    = {
              ~ user_data                = REDACTED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant