Skip to content

Commit 8c50b33

Browse files
authored
Minor fix to monitoring ci/cd (#320)
* Minor fix to monitoring ci/cd * Add message regards legacy metrics * Update docs
1 parent 45a5edb commit 8c50b33

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed

.github/workflows/build-monitoring.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ jobs:
5757
cohctl get monitoring
5858
curl -s http://127.0.0.1:9090/-/healthy
5959
curl -s http://127.0.0.1:3000/api/health
60-
cohctl stop monitoring
60+
cohctl stop monitoring -y
6161
6262
- uses: actions/upload-artifact@v4
6363
if: failure()

docs/reference/monitoring.adoc

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,14 @@ After you start the monitoring you can start a local cluster using `cohctl start
2323
2424
See the Coherence documentation to {commercial-docs-base-url}/manage/using-coherence-metrics.html[setup up Coherence metrics] on your own cluster.
2525
26-
NOTE: You must have a `docker` version installed and running on your machine that includes the updated `docker compose` command.
26+
If you are running a Coherence version before 14.1.2-0-0 or 25.03, you must set the following property on each
27+
cluster member to emit the new style metrics used by the latest dashboards.
28+
29+
- `-Dcoherence.metrics.legacy.names=false`.
30+
31+
If you have a `docker` version installed and running on your machine that doesn't include the updated `docker compose` command,
32+
you can use the `-D` option for `cohctl start manitoring` to use `docker-compose`.
33+
2734
2835
* <<init-monitoring, `cohctl init monitoring`>> - initialize local monitoring for Coherence
2936
* <<start-monitoring, `cohctl start monitoring`>> - starts the local monitoring stack

pkg/cmd/monitoring.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,10 @@ Prometheus using docker compose.`,
226226

227227
grafanaURL := fmt.Sprintf("http://localhost:%v/d/coh-main/coherence-dashboard-main", grafanaPort)
228228
cmd.Printf("\nOpen the Grafana dashboard at %s, using admin/admin\n\n", grafanaURL)
229+
cmd.Println("Note: If you are running a Coherence version before 14.1.2-0-0 or 25.03, you must set the following")
230+
cmd.Println("property on each cluster member to emit the new style metrics used by the latest dashboards:")
231+
cmd.Println(" -Dcoherence.metrics.legacy.names=false")
232+
cmd.Println()
229233

230234
err = mon.dockerCommand([]string{"ps"})
231235
if err != nil {

0 commit comments

Comments
 (0)