Address sonarcloud issues (#71)

Author: tmiddlet2666

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/helper/JMXRequestSender.java

@@ -584,11 +584,7 @@ protected String getFederationManagerObjectName(String sService)
         // look up the full name of the MBean in case we are in container
         Set<ObjectName> setResult = getCompleteObjectName(new ObjectName(sQuery));
 
-        for (Object oResult : setResult)
-            {
-            return oResult.toString();
-            }
-        return null;
+        return setResult.isEmpty() ? null : setResult.iterator().next().toString();
         }
 
 
@@ -602,13 +598,7 @@ protected String getFederationManagerObjectName(String sService)
      */
     private String getFirstResult(Set<ObjectName> setResult)
         {
-        String sFQN = null;
-
-        if (!setResult.isEmpty())
-            {
-            sFQN = setResult.iterator().next().toString();
-            }
-        return sFQN;
+        return setResult.isEmpty() ? null : setResult.iterator().next().toString();
         }
 
     // ------ constants -----------------------------------------------------

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/panel/CoherenceHotCachePanel.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2020, 2022 Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2020, 2023 Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -228,7 +228,7 @@ public void updateData()
                         }
                     if((int) entry.getValue().getColumn(HotCacheData.Max3)!=Integer.MIN_VALUE)
                         {
-                        GraphHelper.addValuesToHotcacheGraph(m_hotcacheGraph3,(double) entry.getValue().getColumn(HotCacheData.Mean3), Integer.valueOf((int) entry.getValue().getColumn(HotCacheData.Max3)).longValue(), Integer.valueOf((int) entry.getValue().getColumn(HotCacheData.Min3)).longValue());
+                        GraphHelper.addValuesToHotcacheGraph(m_hotcacheGraph3,(double) entry.getValue().getColumn(HotCacheData.Mean3), (long) entry.getValue().getColumn(HotCacheData.Max3), (long) entry.getValue().getColumn(HotCacheData.Min3));
                         }
                     if((long) entry.getValue().getColumn(HotCacheData.Max4)!=Long.MIN_VALUE)
                         {
@@ -244,7 +244,7 @@ public void updateData()
                         }
                     if((int) entry.getValue().getColumn(HotCacheData.Max7)!=Integer.MIN_VALUE)
                         {
-                        GraphHelper.addValuesToHotcacheGraph(m_hotcacheGraph7, (double) entry.getValue().getColumn(HotCacheData.Mean7), Integer.valueOf((int) entry.getValue().getColumn(HotCacheData.Max7)).longValue(), Integer.valueOf((int) entry.getValue().getColumn(HotCacheData.Min7)).longValue());
+                        GraphHelper.addValuesToHotcacheGraph(m_hotcacheGraph7, (double) entry.getValue().getColumn(HotCacheData.Mean7), (long) entry.getValue().getColumn(HotCacheData.Max7), (long) entry.getValue().getColumn(HotCacheData.Min7));
                         }
                     break;
                     }

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/panel/util/AbstractMenuOption.java

@@ -296,7 +296,7 @@ protected VisualVMModel getMode()
     protected int getSelectedRow()
         {
         int nSelectedRow = f_jtable != null ? f_jtable.getSelectedRow() : -1;
-        if (nSelectedRow != -1)
+        if (nSelectedRow != -1 && f_jtable != null)
             {
             // set the correct model row index taking into account sorting
             nSelectedRow = f_jtable.convertRowIndexToModel(nSelectedRow);

coherence-visualvm-plugin/src/main/java/com/oracle/coherence/plugin/visualvm/tablemodel/model/PersistenceData.java

@@ -375,13 +375,7 @@ private Data createData(String sServiceName, String sPersistenceMode, String sDo
             Set<ObjectName> setResult = requestSender
                     .getCompleteObjectName(new ObjectName(getMBeanName(sServiceName)));
 
-            String sFQN = null;
-
-            for (Object oResult : setResult)
-                {
-                sFQN = oResult.toString();
-                break;
-                }
+            String sFQN = setResult.isEmpty() ? null : setResult.iterator().next().toString();
 
             sStatus = requestSender.getAttribute(new ObjectName(sFQN), "OperationStatus");
             }