fix: return skip result instead of fail when source not downloaded

Signed-off-by: behnazh-w <[email protected]>

Author: behnazh-w

src/macaron/malware_analyzer/pypi_heuristics/metadata/type_stub_file.py

@@ -44,7 +44,7 @@ def analyze(self, pypi_package_json: PyPIPackageJsonAsset) -> tuple[HeuristicRes
         # To improve accuracy, we should also check for stub files in the wheel distribution.
         result = pypi_package_json.download_sourcecode()
         if not result:
-            return HeuristicResult.FAIL, {"message": "No source code files have been downloaded.", "pyi_files": 0}
+            return HeuristicResult.SKIP, {"message": "No source code files have been downloaded.", "pyi_files": 0}
 
         file_count = sum(
             sum(1 for f in files if f.endswith(".pyi"))

tests/malware_analyzer/pypi/test_type_stub_file.py

@@ -66,7 +66,7 @@ def test_analyze_download_failed_raises_error(analyzer: TypeStubFileAnalyzer, py
     """Test the analyzer raises SourceCodeError when source code download fails."""
     pypi_package_json.download_sourcecode.return_value = False
     assert (
-        HeuristicResult.FAIL,
+        HeuristicResult.SKIP,
         {"message": "No source code files have been downloaded.", "pyi_files": 0},
     ) == analyzer.analyze(pypi_package_json)