Fix a memory leak with the pool queue timer map

cjbj · cjbj · commit 85faedf93af5 · 2016-05-18T19:51:50.000+10:00
diff --git a/lib/pool.js b/lib/pool.js
@@ -87,7 +87,7 @@ function checkRequestQueue() {
   if (self._usingQueueTimeout) {
     clearTimeout(payload.timeoutHandle);
 
-    self._connRequestTimersMap[payload.timerIdx] = null;
+    delete self._connRequestTimersMap[payload.timerIdx];
     payload.timeoutHandle = null;
     payload.timerIdx = null;
   }
@@ -122,7 +122,7 @@ function onRequestTimeout(timerIdx) {
     requestIndex = self._connRequestQueue.indexOf(payloadToDequeue);
 
     self._connRequestQueue.splice(requestIndex, 1);
-    self._connRequestTimersMap[timerIdx] = null;
+    delete self._connRequestTimersMap[timerIdx];
 
     payloadToDequeue.getConnectionCb(new Error(nodbUtil.getErrorMessage('NJS-040')));
   }

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ function checkRequestQueue() {`
`87`	`87`	`if (self._usingQueueTimeout) {`
`88`	`88`	`clearTimeout(payload.timeoutHandle);`
`89`	`89`
`90`		`- self._connRequestTimersMap[payload.timerIdx] = null;`
	`90`	`+ delete self._connRequestTimersMap[payload.timerIdx];`
`91`	`91`	`payload.timeoutHandle = null;`
`92`	`92`	`payload.timerIdx = null;`
`93`	`93`	`}`
`@@ -122,7 +122,7 @@ function onRequestTimeout(timerIdx) {`
`122`	`122`	`requestIndex = self._connRequestQueue.indexOf(payloadToDequeue);`
`123`	`123`
`124`	`124`	`self._connRequestQueue.splice(requestIndex, 1);`
`125`		`- self._connRequestTimersMap[timerIdx] = null;`
	`125`	`+ delete self._connRequestTimersMap[timerIdx];`
`126`	`126`
`127`	`127`	`payloadToDequeue.getConnectionCb(new Error(nodbUtil.getErrorMessage('NJS-040')));`
`128`	`128`	`}`