Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OKE OSS Release 1.28.1 #468

Merged
merged 22 commits into from
Jul 4, 2024
Merged

OKE OSS Release 1.28.1 #468

merged 22 commits into from
Jul 4, 2024

Conversation

YashwantGohokar
Copy link
Member

@YashwantGohokar YashwantGohokar commented Jun 21, 2024 •
edited
Loading

Summary of Changes:

  • Added wait in volume expansion for volume to become available
  • Fix security list rule clean up flow for OCI loadbalancer delete calls
  • For externalTrafficPolicy local the healthcheck port security rule should be retained
  • Skip healthcheck port in use for services that are deleted or not of type loadbalancer
  • Added fix to check length of consistent device paths available before attempting read
  • Process updateLoadbalancer if NLB is in failed state
  • Fix CVEs
  • Separating UpdateLoadBalancer flow for Backends from Ensure Load Balancer flow in CCM
  • Moved listener and backendset updates before shape change & other customer error prone operations
  • Changes to parallelise e2e test runs
  • Implement opc-retry-token to ensure no duplicate request are made for same LB/NLB
  • Do not record events for failure to acquire lock for lb sync
  • Add unit test to for merging common tags tags at the time of creation of LB & storage resources
  • Use topology.kubernetes.io labels
  • Set serviceUid as opc-retry-token
  • Bugfix: Ensure backend ssl certificates during Update LoadBalancer Backendsets flow
  • Fix response when no size change in ControllerExpandVolume
  • Avoid change service type in update shape test cases
  • List instances to check for authorization issues to avoid node object deletion in case of a 404 response

E2E Results:
Parallel e2e:

CCM:

CSI:

FVD:

FVP:

@oracle-contributor-agreement Oracle Contributor Agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

  • yashas

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jun 21, 2024
@YashwantGohokar YashwantGohokar requested review from l-technicore and mrunalpagnis and removed request for l-technicore June 27, 2024 07:09
@nt-tryg
Copy link

nt-tryg commented Jul 1, 2024

Thanks to #465 for providing fix for pv storage on no size change - Guess I will say it now that you have just copied his code without tagging or acknowledging him.

Commit with the code cae4de0

l-technicore
l-technicore requested changes Jul 2, 2024
View reviewed changes
hack/run_e2e_test.sh Show resolved Hide resolved
pkg/cloudprovider/providers/oci/load_balancer.go Outdated Show resolved Hide resolved
test/e2e/cloud-provider-oci/load_balancer.go Outdated Show resolved Hide resolved
test/e2e/cloud-provider-oci/load_balancer.go Outdated Show resolved Hide resolved
@l-technicore
Copy link
Member

l-technicore commented Jul 2, 2024 •
edited
Loading

Please take a look at version related changes done during last release:
cd3c0b6#diff-79304ddc7013a24a0eb9755de96a5c6c937fa9dc3e3ac8dd8621d3506239e8bb
eg.

  • VERSION
  • Readme
  • Makefile
  • Doc updates
    • NSG management annotations update in loadbalancer docs

@YashwantGohokar YashwantGohokar force-pushed the oke-oss-release_1.28.1 branch 2 times, most recently from 1ebb25f to e4736fb Compare July 3, 2024 08:57
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Jul 3, 2024
@YashwantGohokar
Copy link
Member Author

Thanks to #465 for providing fix for pv storage on no size change - Guess I will say it now that you have just copied his code without tagging or acknowledging him.

Commit with the code cae4de0

This commit was picked from our internal repository and committed by Yashas. The PR mentioned was not merged to this repo. We had clarified this over the call.

dhananjay-ng and others added 15 commits July 3, 2024 17:14
@dhananjay-ng @YashwantGohokar
Added wait in volume expansion for volume to become available
f60bf39
@pranavsriram8 @YashwantGohokar
fix security list rule clean up flow for OCI loadbalancer delete calls
d50417b
@pranavsriram8 @YashwantGohokar
for externalTrafficPolicy local the healthcheck port security rule sh…
8f9b005 
…ould be retained
@pranavsriram8 @YashwantGohokar
skip healthcheck port in use for services that are deleted or not of …
cf6ece2 
…type loadbalancer
@dhananjay-ng @YashwantGohokar
Added fix to check length of consistent device paths available before…
d5bd83e 
… attempting read
@pranavsriram8 @YashwantGohokar
process updateLoadbalancer if NLB is in failed state
5e84c08
@YashwantGohokar
Fix CVEs identified in non-os packages in CPO image
fa9585e
@l-technicore @YashwantGohokar
Separating UpdateLoadBalancer flow for Backends from Ensure Load Bala…
34bed6c 
…ncer flow in CCM

Moved listener and backendset updates before shape change & other customer error prone operations
@YashasG98 @YashwantGohokar
Changes to parallelise e2e test runs
febb761
@pranavsriram8 @YashwantGohokar
add opc-retry-token
f852399
@l-technicore @YashwantGohokar
Do not record events for failure to acquire lock for lb sync
8d0ca1b
@GouthamML @YashwantGohokar
Add unit test to for merging common tags tags at the time of creation…
0cac409 
… of LB & storage resources

Merge common free-form & defined tags to LB, NLB & FSS during provision

Squashed commit:
fix not using generics to remove Go >=1.18 dependency
@YashwantGohokar
Use topology.kubernetes.io labels
f28c8ab
@pranavsriram8 @YashwantGohokar
set serviceUid as opc-retry-token
cbe5f08
@l-technicore @YashwantGohokar
Bugfix: Ensure backend ssl certificates during Update LoadBalancer Ba…
8788adc 
…ckendsets flow
@YashwantGohokar YashwantGohokar force-pushed the oke-oss-release_1.28.1 branch 2 times, most recently from 376ceed to b869973 Compare July 3, 2024 11:51
mrunalpagnis
mrunalpagnis approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@mrunalpagnis mrunalpagnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes reviewed over call and approved

@mrunalpagnis mrunalpagnis linked an issue Jul 4, 2024 that may be closed by this pull request
[BUG REPORT] PVC failed to resize #466
Closed
l-technicore
l-technicore approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@l-technicore l-technicore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@YashwantGohokar YashwantGohokar changed the title Oke oss release 1.28.1 OKE OSS Release 1.28.1 Jul 4, 2024
@YashwantGohokar YashwantGohokar merged commit ba91d02 into oracle:release-1.28 Jul 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l-technicore l-technicore l-technicore approved these changes

@mrunalpagnis mrunalpagnis mrunalpagnis approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG REPORT] PVC failed to resize
9 participants
@YashwantGohokar @nt-tryg @l-technicore @mrunalpagnis @dhananjay-ng @pranavsriram8 @YashasG98 @GouthamML @AkarshES