Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Refactor app package #36

Open
GNaD13 opened this issue Dec 9, 2024 · 1 comment
Open

Refactor: Refactor app package #36

GNaD13 opened this issue Dec 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@GNaD13
Copy link
Collaborator

GNaD13 commented Dec 9, 2024 •
edited
Loading

Currently, we put all registry module logic in a single file app.go. This is very old style and a bit chaotic when importing more module. Should we open a PR to wasmd repository to update new app package style?
@ducphamle2
Copy link
Collaborator

imo we don't need to refactor it for now. We are forking from wasmd, so refactoring will cause lots of conflicts down the line

@ducphamle2 ducphamle2 added the enhancement New feature or request label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ducphamle2 @GNaD13