Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left-over translations? #65

Open
robho opened this issue Feb 17, 2023 · 1 comment
Open

Left-over translations? #65

robho opened this issue Feb 17, 2023 · 1 comment

Comments

@robho
Copy link

robho commented Feb 17, 2023

I see some strings in app/src/main/res/values/strings.xml that I can't find any other references to (they seem unused). Maybe remove these strings if they're not used?

The strings are:

  • playlist_action_remove
  • compilation_options
  • nowplaying_saveplaylist_message
  • nextbutton_label
  • neverbutton_label
  • customize_menu_title
  • feedback_collecting_logs
  • cancel_notification_desc
  • pref_autodiscovery_summary
  • pref_autodiscovery_title
  • pref_volumecontrol_notification
  • pref_verboselogging_summary
  • pref_verboselogging_title
  • pref_showreleasenotes_summary
  • pref_showreleasenotes_title
@bensandee
Copy link
Contributor

sure, thanks! Certainly don't spent any time translating unused strings.

Some I might leave in case we add the preference back (verbose logging). Others clearly can be removed (release notes).

We'll keep this open and I'll update as I have time to purge unused items.

@bensandee bensandee added good first issue Good for newcomers and removed good first issue Good for newcomers labels Feb 20, 2023
bensandee added a commit that referenced this issue Mar 9, 2024
@bensandee
fix: remove unused strings and translations (resolve issue #65)
a644e3e
bensandee pushed a commit that referenced this issue Mar 9, 2024
@semantic-release-bot
chore(release): OpenSqueeze 2.7.0-alpha.58 [skip ci]
71612af 
# [2.7.0-alpha.58](v2.7.0-alpha.57...v2.7.0-alpha.58) (2024-03-09)

### Bug Fixes

* remove unused strings and translations (resolve issue [#65](#65)) ([a644e3e](a644e3e))
* update build to use more specific keystores (that aren't in git) ([3e15319](3e15319))
* update default opensqueeze keystores ([d4addc0](d4addc0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bensandee @robho