Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(referrers): push manifest with subject #163

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

pat-pan
Copy link
Contributor

@pat-pan pat-pan commented Nov 19, 2024

What this PR does / why we need it

The PR is to implement the feature to push manifest with subject as per the OCI distribution spec v1.1.0.

Which issue(s) this PR resolves / fixes

Resolves / Fixes #159

Please check the following list

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Patrick Pan added 2 commits November 18, 2024 18:16
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan changed the title feature: push manifest with subject feature(referrers): push manifest with subject Nov 19, 2024
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from 952a63a to 7fca0cb Compare November 19, 2024 07:10
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from bd14c4d to edc79f5 Compare November 19, 2024 07:25
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from edc79f5 to 7809549 Compare November 19, 2024 07:26
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from e380c12 to c7e4418 Compare November 19, 2024 07:34
@shizhMSFT shizhMSFT changed the title feature(referrers): push manifest with subject feat(referrers): push manifest with subject Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 90.34091% with 17 lines in your changes missing coverage. Please review.

Project coverage is 82.86%. Comparing base (a9103d2) to head (7df36ca).

Files with missing lines Patch % Lines
.../OrasProject.Oras/Registry/Remote/ManifestStore.cs 86.48% 3 Missing and 7 partials ⚠️
src/OrasProject.Oras/Registry/Remote/Referrers.cs 89.09% 4 Missing and 2 partials ⚠️
src/OrasProject.Oras/Registry/Remote/Repository.cs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   81.70%   82.86%   +1.16%     
==========================================
  Files          35       37       +2     
  Lines        1104     1278     +174     
  Branches      127      152      +25     
==========================================
+ Hits          902     1059     +157     
- Misses        146      154       +8     
- Partials       56       65       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Patrick Pan added 3 commits November 20, 2024 09:21
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
src/OrasProject.Oras/Registry/Remote/ManifestStore.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Oci/Index.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Oci/Index.cs Outdated Show resolved Hide resolved
src/OrasProject.Oras/Registry/Remote/RepositoryOptions.cs Outdated Show resolved Hide resolved
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from 0981e72 to 5041592 Compare November 21, 2024 04:45
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch 2 times, most recently from feaf46d to 1c49d35 Compare November 25, 2024 02:32
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from 1c49d35 to d6e8499 Compare November 25, 2024 02:35
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
Signed-off-by: Patrick Pan <[email protected]>
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from 2906727 to 856c0ef Compare November 29, 2024 05:22
Patrick Pan added 3 commits November 29, 2024 16:50
@pat-pan pat-pan force-pushed the feature/pushManifestWithSubject branch from 89afb0e to 7df36ca Compare December 3, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push Manifest with subject
3 participants