Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Include video durations in estimatedConsumptionMinutes #273

Open
tpreusse opened this issue Jun 8, 2019 · 0 comments
Open

Include video durations in estimatedConsumptionMinutes #273

tpreusse opened this issue Jun 8, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@tpreusse
Copy link
Contributor

tpreusse commented Jun 8, 2019

Bug Report

Steps to Reproduce

{
  document(path: "/2019/06/08/das-verlorene-paradies") {
    meta {
      totalMediaMinutes
      estimatedReadingMinutes
      estimatedConsumptionMinutes
    }
    content
  }
}

Live Query

Additional issue: if content is not requested totalMediaMinutes is 0 because it's resolved at request time.

Actual Results

{
  "data": {
    "document": {
      "meta": {
        "totalMediaMinutes": 19,
        "estimatedReadingMinutes": 4,
        "estimatedConsumptionMinutes": 4
      },
      "content": {} // clipped
  }
}

Expected Results

{
  "data": {
    "document": {
      "meta": {
        "totalMediaMinutes": 19,
        "estimatedReadingMinutes": 4,
        "estimatedConsumptionMinutes": 23
      },
      "content": {} // clipped
  }
}

Possible Solutions

  • preprocess totalMediaMinutes at index time
  • add totalMediaMinutes to estimatedConsumptionMinutes unless meta.audioSource.durationMs is present
    • this should still win for e.g. «An der Bar» cases where there is a video and audio file of the same thing and same duration
@patrickvenetz patrickvenetz added the enhancement New feature or request label Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants