Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Refactor Slack Messages API #501

Open
caillou opened this issue Sep 3, 2020 · 0 comments
Open

Refactor Slack Messages API #501

caillou opened this issue Sep 3, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@caillou
Copy link
Contributor

caillou commented Sep 3, 2020

The Slack messages API is currently inconsistent.

// packages/slack/lib/publish.js
publish()
postMessage()

The publish() and postMessages() mehtods in https://github.com/orbiting/backends/blob/master/packages/slack/lib/publish.js do not return promises, nor do any of the methods in https://github.com/orbiting/backends/blob/master/packages/republik/lib/slack.js.

Yet, most of the code relies on these methods returning promises.

There is an attempt at refactoring the code here: 4ef98c2

Yet, the questions remains open, if these methods should return promises at all.

It is event questionable, if the Slack API should be used in our code, or if we should just log to the console and react to it separately.

@patrickvenetz patrickvenetz added the enhancement New feature or request label Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants