Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript compatibility issues #419

Open
ef4 opened this issue Mar 5, 2023 · 2 comments
Open

Typescript compatibility issues #419

ef4 opened this issue Mar 5, 2023 · 2 comments

Comments

@ef4
Copy link
Contributor

ef4 commented Mar 5, 2023

ember-orbit builds its typescript inside the app's build. While ember-cli-typescript historically encouraged that behavior, it was not a good idea, and it makes a bunch of potential type problems leak out of the library and into the app.

For now, if anyone else is dealing with typescript problems in ember-orbit, I'm maintaining a version that publishes to NPM with the typescript precompiled. I use it via https://pnpm.io/aliases like:

"ember-orbit": "npm:@ef4/[email protected]",

This version works without any type errors under Ember 4.10+, including the Ember's native preview types.

@antepenavasyfl
Copy link

Hi @ef4, I have similar issues with ember-orbit, you think your package would help here?

Screenshot 2024-01-21 at 18 32 06 Screenshot 2024-01-21 at 18 32 38

@antepenavasyfl
Copy link

ps I am trying to migrate to 3.28 from 3.22 atm, but of course my goal after that is to continue upgrade to v4 and beyond

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants