From 269716e4ce6fa0a111c5ea8f8c3ddde36156217d Mon Sep 17 00:00:00 2001 From: Ido Zilberberg Date: Wed, 25 Sep 2019 15:12:41 +0300 Subject: [PATCH] Skip broken tests, see inline and https://github.com/orbs-network/orbs-network-go/issues/1346 --- test/acceptance/memory_leak_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/acceptance/memory_leak_test.go b/test/acceptance/memory_leak_test.go index 21fface66..34f3e66d7 100644 --- a/test/acceptance/memory_leak_test.go +++ b/test/acceptance/memory_leak_test.go @@ -23,6 +23,7 @@ import ( // therefore, this file is marked on top with a build flag ("memoryleak") meaning without this flag it won't build or run // to run this test, add to the go command "-tags memoryleak", this is done in test.sh while making sure it's the only test running func TestMemoryLeaks_OnSystemShutdown(t *testing.T) { + t.Skip("This test is not useful, we only care about memory leaks during runtime and this is covered by the monitoring project 'marvin': https://github.com/orbs-network/marvin") dir := os.Getenv("PPROF_DIR") absPath, err := filepath.Abs("../../" + dir) @@ -81,6 +82,7 @@ func TestMemoryLeaks_OnSystemShutdown(t *testing.T) { } func TestMemoryLeaks_DuringRuntime(t *testing.T) { + t.Skip("This test is incorrect - should modify it to take memory samples within TestGazillion instead, see https://github.com/orbs-network/orbs-network-go/issues/1346") dir := os.Getenv("PPROF_DIR") absPath, err := filepath.Abs("../../" + dir)