Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block storage GetLastCommittedBlockHeight api is problematic #107

Open
jlevison opened this issue Oct 31, 2018 · 1 comment
Open

block storage GetLastCommittedBlockHeight api is problematic #107

jlevison opened this issue Oct 31, 2018 · 1 comment

Comments

@jlevison
Copy link
Contributor

it returns the block height and the timestamp in a struct
using it requires to box and unbox the result each time - makes little sense when all we need is the block height

in actual, it is not used today in the system
what is used is LastBlockHeight(), 94 times i believe

can we change it?

@OdedWx
Copy link
Contributor

OdedWx commented Nov 14, 2018

Depends on: #109

We added the block time for CallContarcts that were called by the PublicAPI.
Currently PublicAPI doesn't use the block height/time as the flow was changed to get the height/time from the state storage. Let's close #109 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants