Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network_type value unused #174

Open
ronnno opened this issue May 21, 2019 · 0 comments
Open

Network_type value unused #174

ronnno opened this issue May 21, 2019 · 0 comments
Assignees

Comments

@ronnno
Copy link
Contributor

ronnno commented May 21, 2019

relates to #88
relates to #146

network_type (sometimes referred to as network_id) configuration values are unused (reserved value 0 is used for all networks). TBD if to deprecate this field, replace it's implementation or reinstate it as originally intended.

This affects allocation of virtual chain ids. If deprecating this value virtual chain id's uniqueness should be enforced across all deployed Orbs networks.. there is no mechanism to enforce this. what are the implications of having virtual chain name collisions?...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants