Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TRANSACTION_STATUS_REJECTED_SYSTEM_ERROR #185

Open
talkol opened this issue Mar 5, 2019 · 1 comment
Open

Add TRANSACTION_STATUS_REJECTED_SYSTEM_ERROR #185

talkol opened this issue Mar 5, 2019 · 1 comment

Comments

@talkol
Copy link
Member

talkol commented Mar 5, 2019

This is required when we're adding a new transaction, calling the preOrder check contract and the contract execution fails due to some reason.. this means that we're rejecting the transaction because of a system error

  1. Add to spec

  2. Add to all clients sdks + gamma-cli

  3. Return it in services/transactionpool/add_new_transaction.go here:

if err := s.validateSingleTransactionForPreOrder(ctx, input.SignedTransaction); err != nil {
    status := protocol.TRANSACTION_STATUS_REJECTED_SMART_CONTRACT_PRE_ORDER // TODO: change to system error
@electricmonk
Copy link
Contributor

@OdedWx this is a protocol change - please consider

@electricmonk electricmonk transferred this issue from orbs-network/orbs-network-go Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants