Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "borg" connection manager with thread safe db pool #397

Open
chicco785 opened this issue Nov 18, 2020 · 3 comments
Open

Replace "borg" connection manager with thread safe db pool #397

chicco785 opened this issue Nov 18, 2020 · 3 comments
Assignees

Comments

@chicco785
Copy link
Contributor

Pools are not offered in the basic driver of crate and psql. It would be good to explore a proper db pool.

Originally posted by @chicco785 in #373 (comment)

@github-actions
Copy link
Contributor

Stale issue message

@daminichopra
Copy link
Contributor

daminichopra commented Dec 6, 2021

Hi @chicco785 @c0c0n3 , Please assign this issue to me if no one is working on it.
Also , Shall I take reference of this comment for further fix of this issue?

Thank You.

@c0c0n3
Copy link
Member

c0c0n3 commented Jan 4, 2022

Hi @daminichopra thanks for offering to work on this. Please read through the comments to crate/crate-python#407. I think one option we should consider is to swap out pg8000 for Psycopg in the Postgres translator. Then see if Psycopg would work with Crate too, since it looks like Crate should support the PG wire protocol quite well these days?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants