Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested popups - parent disappears (filter -> DateTimer) #2926

Open
StefanPruzinsky opened this issue Nov 26, 2024 · 2 comments
Open

Nested popups - parent disappears (filter -> DateTimer) #2926

StefanPruzinsky opened this issue Nov 26, 2024 · 2 comments
Assignees
Labels

Comments

@StefanPruzinsky
Copy link

StefanPruzinsky commented Nov 26, 2024

Describe the bug
When I put DataTimers into filters and I click on year field, month field or arrows to switch month, the filter pop-up in the background disappears.
Is there any solution for this?

To Reproduce
Steps to reproduce the behavior:

  1. Create custom filter with DateTimer input
  2. Create Selection, attach custom filter
  3. Append selection to layout array in Screen

Expected behavior
The filter pop-up should remain visible until it is closed by Apply button or by clicking outside of both filter popup and nested pop-ups (such as DateTimer's pop-up)

Screenshots
IMAGE 2024-11-26 09:49:12
IMAGE 2024-11-26 09:49:09

Desktop:

  • OS: macOS
  • Browser: chrome, safari
  • Version: latest

Smartphone:

  • not tested yet

Server:

  • Platfrom Version: 14.34.0
  • Laravel Version: 10.48.20
  • PHP Version: 8.2
  • Database: Postgres
  • Database Version: 15

Additional context
I was told, it has been resolved once, however, it seems the problem arose again. We would also greatly appreciate the ability to change the filter pop-up width and to disable autofocus on first filter's input. We are currently building the internal system for the third largest radio station in Slovakia on the top of Orchid and things like these really suck. We would really appreciate any help.

@tabuna
Copy link
Member

tabuna commented Nov 26, 2024

I'm sorry to hear you ran into this issue. To prevent the dropdown from closing when interacting with the calendar, you can add the static method to your method chain, like this:

DateTimer::make('created_at')
    ->static();

I’m not entirely sure why this isn’t the default behavior, but I’ll look into it and make sure we improve the experience going forward.

@StefanPruzinsky
Copy link
Author

StefanPruzinsky commented Nov 27, 2024

Thank you @tabuna for your fast response, it works as expected now. Only one more bug that occurs when combining static() with allowEmpty():
Screenshot 2024-11-27 at 13 13 45
It pushes text removal button to the next line.
Would be great to make it default behaviour, I totally agree. Consider autofocus disabling option and changeable width of filter pop-up as well. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants