Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte v5 support? #106

Open
webJose opened this issue Oct 22, 2024 · 8 comments
Open

Svelte v5 support? #106

webJose opened this issue Oct 22, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@webJose
Copy link

webJose commented Oct 22, 2024

Plans on supporting the new Svelte?

@orefalo
Copy link
Owner

orefalo commented Oct 22, 2024

Eventually, yes, it's on my to-do list.

I just lack the motivation at the moment because I am working on a tree component. I have marked many tickets as enhancements, and those will probably make it after triage, support for both px and % is something I really want ot implement.

So no date,
Feel free to chip in...;-)

@bcspragu
Copy link

bcspragu commented Oct 30, 2024

I'm in the market for a splitpane library for Svelte 5, so I'll give this a shot :)

I'll first try running the automated migration tools, and see where that gets me

@orefalo
Copy link
Owner

orefalo commented Oct 30, 2024

Initiative welcomed,
The component works perfectly with svelte 5 as it is. Not surprising, the migration tool works as well
sv migrate svelte5 .

I was considering addressing the functional gaps in this new svelte5 - but I don't have time right now.

[ ] Rethink constraints with a pixel first approach, and a % calculation atop (What's the best approach to define constraints?)
[ ] Implement proper fallbacks, when sizing constraints are not specified, the positioning should default to the browser's
[ ] Make this component headless with proper separation of Model and View
[ ] Make SnapLogic better handle reactivity of other split-panes components
[ ] More demos with typical use cases found across the internet (Snapping SideBar, UI with fat splitters..etc)
[ ] Implement proper accessibility
[ ] Dark Theme
[ ] Rework the landing page on GitHub

@orefalo orefalo added the enhancement New feature or request label Oct 30, 2024
@bcspragu
Copy link

The component works perfectly with svelte 5 as it is.

Can confirm, I just changed the peerDependencies to include "svelte": "^5.0.0" and it appears to work with zero other changes in my Svelte 5 app.

Perhaps that's enough of a change for now, just updating the peerDependencies so people on Svelte 5 can use your (awesome) library without npm i --force?

@orefalo
Copy link
Owner

orefalo commented Oct 30, 2024

oh, interesting...
but then... this will force an upgrade to svelte 5, right?

How would I tell npm to support v4 & v5?

@orefalo
Copy link
Owner

orefalo commented Oct 30, 2024

found it

"dependency-name": "1.0.0 || 2.0.0"

@orefalo
Copy link
Owner

orefalo commented Oct 30, 2024

v8.0.9 released - give it a few minutes to reach npm

@bcspragu
Copy link

bcspragu commented Nov 1, 2024

v8.0.9 released - give it a few minutes to reach npm

Works great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants