Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pixel sizing support #58

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

feat: pixel sizing support #58

wants to merge 16 commits into from

Conversation

Tal500
Copy link
Collaborator

@Tal500 Tal500 commented Jan 22, 2023 •
edited
Loading

work in progress, still on draft.

Roadmap?:

  1. Use calc(% + px) to handle the splitter size, so the sizing will be expected and there will be no overflow. This would also simplify the dragging code. (Done! in bc48c47)
  2. Allow sizing in pixels.
  3. Use CSS min and max properties (when needed) to enforce minimum and maximum mixed with PX and %.
  4. Allow the size var to be a string in the format of Xpx or X%, including two way binding. If it is a number, then it's the size in %.
  5. docs. Maybe also an intractive two-way binding fancy example with many sliders

Closes #33
Closes #38

@Tal500 Tal500 changed the title chore: start working on pixel support feat: pixel sizing support Jan 23, 2023
@elsoazemelet
Copy link

This is indeed very helpful and currently we would like to use in our project, is this possible to be merged anytime soon?

@Tal500
Copy link
Collaborator Author

Tal500 commented Mar 29, 2023

This is indeed very helpful and currently we would like to use in our project, is this possible to be merged anytime soon?

Hi! This is unmerged because there is a lot of refractoring to do.
Sadly, can't promise it right now because of my own limited time and the huge API and structure change (that wasn't confirmed yet), so don't count on this as for now.

Thankfully. there are many ways to overcome this issue by listening to events of the window resize and programmatically convert the pixel amount to percentages.

@wtachau
Copy link
Contributor

wtachau commented Jun 13, 2023

bump— would love to see this land :)

@ctwhome
Copy link

ctwhome commented Dec 19, 2023

are you planning to continue this work?

@Tal500
Copy link
Collaborator Author

Tal500 commented Dec 19, 2023

are you planning to continue this work?

Sadly I have no time for this work.. But any suggestion/contribution is welcome. This is a good road and initial design in my opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't resize one pane when container size changes Set min height and width in px
4 participants
@Tal500 @elsoazemelet @wtachau @ctwhome