handleLoadPackage invoked 2 times when a module is loaded

[yashikada]

I'm testing a module, I'm a beginner.
In my handleLoadPackage there is a simple Log.v and nothing more.
I see a strange behaviour, when I run module the log is printed 2 times, while I run the hooked app the log is printed only one time.
I tested the latest version, version 1.8.1 and 1.8.0 I got always the same bahaviour.
I can make an issue if is an issue.

[yujincheng08]

handleLoadPackage can be invoked multiple times. This is expected even for the original Xposed. Check XC_LoadPackage.LoadPackageParam.isFirstApplication

[ryuunoakaihitomi]

isFirstApplication is broken.

package android.playground;

import android.util.Log;

import androidx.annotation.Keep;

import de.robv.android.xposed.IXposedHookLoadPackage;
import de.robv.android.xposed.IXposedHookZygoteInit;
import de.robv.android.xposed.callbacks.XC_LoadPackage;

@Keep
public class MainHook implements IXposedHookZygoteInit, IXposedHookLoadPackage {

    private static final String TAG = "MainHook";

    @Override
    public void handleLoadPackage(XC_LoadPackage.LoadPackageParam lpparam) {
        Log.d(TAG, "handleLoadPackage: XC_LoadPackage.LoadPackageParam -> pkgName:" + lpparam.packageName + ", procName:" + lpparam.processName + ", isFirstApp:" + lpparam.isFirstApplication);
    }

    @Override
    public void initZygote(StartupParam startupParam) {
        Log.d(TAG, "initZygote: StartupParam -> modulePath:" + startupParam.modulePath + ", startsSystemServer:" + startupParam.startsSystemServer);
    }
}

2022-04-14 10:39:22.149 7687-7687/android.playground D/MainHook: handleLoadPackage: XC_LoadPackage.LoadPackageParam -> pkgName:android.playground, procName:android.playground, isFirstApp:true
2022-04-14 10:39:22.150 7687-7687/android.playground D/MainHook: handleLoadPackage: XC_LoadPackage.LoadPackageParam -> pkgName:android.playground, procName:android.playground, isFirstApp:true

[yujincheng08]

@ryuunoakaihitomi could you print the backtrace out?

[ryuunoakaihitomi]

    @Override
    public void handleLoadPackage(XC_LoadPackage.LoadPackageParam lpparam) {
        Log.d(TAG, "handleLoadPackage: XC_LoadPackage.LoadPackageParam -> pkgName:" + lpparam.packageName + ", procName:" + lpparam.processName + ", isFirstApp:" + lpparam.isFirstApplication);
        Log.d(TAG, "handleLoadPackage: ", new Throwable("?"));
    }

2022-04-14 14:02:39.460 4447-4447/android.playground D/MainHook: handleLoadPackage: XC_LoadPackage.LoadPackageParam -> pkgName:android.playground, procName:android.playground, isFirstApp:true
2022-04-14 14:02:39.462 4447-4447/android.playground D/MainHook: handleLoadPackage: 
    java.lang.Throwable: ?
        at android.playground.MainHook.handleLoadPackage(MainHook.java:19)
        at de.robv.android.xposed.IXposedHookLoadPackage$Wrapper.handleLoadPackage(Unknown Source:2)
        at de.robv.android.xposed.callbacks.XC_LoadPackage.call(Unknown Source:6)
        at de.robv.android.xposed.callbacks.XCallback.callAll(Unknown Source:26)
        at H.afterHookedMethod(Unknown Source:104)
        at de.robv.android.xposed.XposedBridge$AdditionalHookInfo.callback(Unknown Source:132)
        at LSPHooker_.getClassLoader(Unknown Source:8)
        at android.app.LoadedApk.getResources(LoadedApk.java:956)
        at android.app.ContextImpl.createAppContext(ContextImpl.java:2282)
        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5722)
        at java.lang.reflect.Method.invoke(Native Method)
        at org.lsposed.lspd.nativebridge.HookBridge.invokeOriginalMethod(Native Method)
        at de.robv.android.xposed.XposedBridge$AdditionalHookInfo.callback(Unknown Source:103)
        at LSPHooker_.handleBindApplication(Unknown Source:11)
        at android.app.ActivityThread.-wrap1(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1685)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:176)
        at android.app.ActivityThread.main(ActivityThread.java:6651)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:547)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:824)
2022-04-14 14:02:39.463 4447-4447/android.playground D/MainHook: handleLoadPackage: XC_LoadPackage.LoadPackageParam -> pkgName:android.playground, procName:android.playground, isFirstApp:true
2022-04-14 14:02:39.465 4447-4447/android.playground D/MainHook: handleLoadPackage: 
    java.lang.Throwable: ?
        at android.playground.MainHook.handleLoadPackage(MainHook.java:19)
        at de.robv.android.xposed.IXposedHookLoadPackage$Wrapper.handleLoadPackage(Unknown Source:2)
        at de.robv.android.xposed.callbacks.XC_LoadPackage.call(Unknown Source:6)
        at de.robv.android.xposed.callbacks.XCallback.callAll(Unknown Source:26)
        at H.afterHookedMethod(Unknown Source:104)
        at de.robv.android.xposed.XposedBridge$AdditionalHookInfo.callback(Unknown Source:132)
        at LSPHooker_.getClassLoader(Unknown Source:8)
        at android.app.LoadedApk.getResources(LoadedApk.java:956)
        at android.app.ContextImpl.createAppContext(ContextImpl.java:2282)
        at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5722)
        at java.lang.reflect.Method.invoke(Native Method)
        at org.lsposed.lspd.nativebridge.HookBridge.invokeOriginalMethod(Native Method)
        at de.robv.android.xposed.XposedBridge$AdditionalHookInfo.callback(Unknown Source:103)
        at LSPHooker_.handleBindApplication(Unknown Source:11)
        at android.app.ActivityThread.-wrap1(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1685)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:176)
        at android.app.ActivityThread.main(ActivityThread.java:6651)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:547)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:824)

[yujincheng08]

@ryuunoakaihitomi Let's follow it in #1844

[yashikada]

with commit b5aff15 handleLoadPackage is invoked only one time without check isFirstApplication