would you refactor BottomControlButton class?

[hyunsu15]

this code has below method

 private static int getIdentifier(String str, String str2) {
        Context appContext = ReVancedUtils.getContext();
        return appContext.getResources().getIdentifier(str, str2, appContext.getPackageName());
    }

but ReVancedUtils has getIdentifier method.

   public static int getIdentifier(String name, String defType) {
        Context context = getContext();
        return context.getResources().getIdentifier(name, defType, context.getPackageName());
    }

so i suggest

private static int getIdentifier(String name, String defType) {
            ReVancedUtils.getIdentifier(name,defType);
   }

[oSumAtrIX]

Yes, that sounds good, but instead of your last code-block, simply use ReVancedUtils.getIdentifier wherever you'd use getIdentifier.

[hyunsu15]

yes, then getInteger() method, getAnimation() method will correct.

BottomControlButton's current methods

 private static int getInteger(String str) {
        return ReVancedUtils.getContext().getResources().getInteger(getIdentifier(str, "integer"));
    }

    private static Animation getAnimation(String str) {
        return AnimationUtils.loadAnimation(ReVancedUtils.getContext(), getIdentifier(str, "anim"));
    }

you choose those methods or getIndentifier method correct

i think good answer when you choose any thing.

[oSumAtrIX]

You would do:

 private static int getInteger(String str) {
-        return ReVancedUtils.getContext().getResources().getInteger(getIdentifier(str, "integer"));
+        return ReVancedUtils.getContext().getResources().getInteger(ReVancedUtils.getIdentifier(str, "integer"));
}

private static Animation getAnimation(String str) {
-       return AnimationUtils.loadAnimation(ReVancedUtils.getContext(), getIdentifier(str, "anim"));
+       return AnimationUtils.loadAnimation(ReVancedUtils.getContext(), ReVancedUtils.getIdentifier(str, "anim"));
}

[hyunsu15]

then, can i remove BottomControlButton's dentifer method?

[oSumAtrIX]

Yep