No suggestion button while clicking on a commit of the pull request

[Eleven1Liu]

Hi Github team,

I'm trying to review the latest commit of a pull request, but there's no Insert a suggestion button in the comment field.
Therefore, I have to use ```suggestion This is a suggestion.``` to add the suggestion.
Is that an expected behavior? Or the users are expected to find the suggestion button through the tab Files Changed.
Do you have any suggestions? Thanks!!

Behavior

Step 1. Click on the latest PR (so we don't have to go through changes in the previous review)

Step 2. Start a review and try to add a suggestion.

Feature Request

A suggestion button for reviewers to add suggestion to the commit of a PR like the one in tab Files Changed.

[roro-lv]

+1

[maross]

+1

[jameshelou]

+1

[brx-elon]

+1

[laurentjacob]

+1

[ayberkozgur]

+1, never understood why this happens but feels like an oversight

[Farigh]

+1 this is really annoying when reviewing PRs with many commits

[mfdebian]

Thank god I'm not the only one, anyone know a way to fix this? I no longer get the expected bar with the options!

[ander-murane]

+1

[bahar-p]

+1

[rauno-tali]

+1

[sneakyvv]

+1

[richcooper95]

I'm guessing the reason this doesn't exist is that the 'suggest changes' change can be immediately committed to the PR branch by the author via 'commit suggestion' -- but that might not be possible if the lines you're suggesting changes for don't exist in the overall changes of the PR (i.e. because they've been changed again in a later commit).

I still think a 'suggest changes' at the per-commit level would be very useful in most cases (if the commit history is sane and doesn't overlap changes) rather than disabling it altogether -- a couple of potential ways to allow this might be:

1. Allow 'suggest changes' in commits, but disable the 'commit suggestion' button if the changes were suggested in a specific commit.
2. Allow 'suggest changes' in commtis, but disable the 'commit suggestion' button if the changes can't be applied to the overall PR changes in a separate commit.

EDIT: Just realised the OP was asking specifically about suggesting changes for the latest commit -- that could also be one of the scenarios where 'suggest changes' is allowed!

[anibalcesar]

+1

[huang-weijie]

+1

[kreintjes]

This feature ("just a simple button" ™️) would still be highly appreciated by me and my team. In this case it really feels like just a button, since the feature works perfectly when typing ```suggestion yourself, copy-pasting the old code and then editing it. I use it for a long time now and no issues with it, except that it's cumbersome to have to type and copy-paste it yourself every time. A button for this when placing a comment on a single commit would be much easier. Feels strange this option is only available in the (all) Files changed tab.

We are 1.5 year further since the original suggestion and still no answer from anyone from GitHub at all (as far as I can tell) 😞

[ayberkozgur]

So true, I feel like we should have gone with Gitlab instead

[worblehat]

+1

[felixmeziere]

+1

[Shannon890]

+1

[mauriciogracia]

The Add code suggestion button is only available when you are checking "Files changed" which is the general view of all the commit changes

Here is the button

[Farigh]

This is the whole point of this issue : to add this button when filtering on a (subset of) commit(s)

[mauriciogracia]

I got here because I could not find that button, I'm just providing a way for anyone else to find it.

Also what if a certain commit made changes to 3 lines of code, and then a next commit remove them, the code suggestion will be obsolete, for me that is the reason is located in the FILES CHANGED and not for every commit

[DanKaplanSES]

I got here because I could not find that button, I'm just providing a way for anyone else to find it.

That's one way to find it, but it didn't help me. It seems you can't make a suggestion once a PR has been merged. That may be what some people are running into.

As you may be able to tell, I'm much more familiar with Git than GitHub. After a git merge, it's perfectly fine to continue working on either branch and merge again. A PR seems similar to a git merge, so the latter is my frame of reference, but these are separate concepts. Once you've merged a PR, you can't merge the PR a second time. Therefore, from a GitHub perspective, it makes sense for the suggestion button to disappear once you've merged a PR.

That being said, I think it would be a much better user experience if the button were disabled with a helpful tool tip to explain why it can't be used.

Note: I'm aware this doesn't relate to the OP, but like @mauriciogracia , I found this thread because I googled for why I can't find the suggestion button.

[MarkoPaul0]

Seems like this button was removed between yesterday and today for me. It was very convenient, don't know why they did this.

[anthony-costar]

Is the pull request already merged? If so, you can't add a suggestion after the fact. The button should still be there for open pull requests.

[Yoftahe1]

❤️

[sricks]

This functionality would be useful for commits and already-merged PRs. Yes, the "implement suggestion" won't work, but it's a useful way to show what the requested change is (vs explaining it with sentences). Github should simply remove the "implement" button when it's not relevant.

[alexhwoods]

Note, you can just type the suggestion as a code block, e.g.

[alexhwoods]

That being said, Github, please add the button! It seems so simple

[Sh-Pe]

+1

[DanieleTrapani]

+1