Help on Step 1 Activity 2 | continuous-delivery-azure

[KittyChiu]

"On staging workflow update" job is failing. I have checked the permissions for

• GITHUB_TOKEN - Allow GitHub Actions to create and approve pull requests
• GITHUB_TOKEN - Read and write permissions

I think the automated tutorial script is missing adding spinup-destroy.yml into azure-configuration branch. Before line 80 in 2-setup-azure-environment.yml, you are missing some code there.

[slgraff]

I've experienced the same problem.

[AnttiHal]

Same problem here.

[markpatterson27]

Step 1 is titled 'Trigger a job based on labels' and step 2 starts with 'Nice work triggering a job on specific labels'. At no point in step 1 do you actually trigger a job based on a label, or am I missing something? The only thing you do in Step 1 is create an invalid workflow (because it has no steps), and create a plain PR for the new file. The intended learning outcome for step 1 isn't achieved (in step 1).

Am I missing something? Maybe activity 2 should include a valid workflow (a 'hello-world' step would do) and then include an activity 3 that triggers it.

[markpatterson27]

The error is because you can't create a PR with no commits in it. There must be a difference in history between HEAD and base refs.

It looks like there used to be example workflows in the course repo, one of which was copied into the workflows dir and commited by the create-workflow-pr.sh script. The demo scripts were taken out and the create-workflow-pr.sh script was altered, taking out the 'Added' workflow file commit.

As @KittyChiu said, spinup-destroy.yml needs to be added back in somewhere and commited to the azure-configuration branch before the new PR is opened.

Should the creation of the file and PR be automated, or would it be better to add it as a user activity?

(The needed spinup-destroy.yml file can be found in the course repo history if anyone is looking for it.)

[markpatterson27]

I've created a PR for this issue [WIP].

At a guess, I assume the missing workflow was removed because adding a workflow file is out of scope for the default GITHUB_TOKEN. This leaves the options of either having the learner create a workflow scoped PAT and adding it to their course repo, or having the learner create the missing workflow themselves. If anyone has views on which learner activity would be better, I'd appreciate the input. Thank you.

[jhoffman3]

As a rank beginner with github actions and Azure, even with the help of your comments and PR, it wasn't possible for me to create and use a scoped PAT to get around the workflow perm errors for azure-configuration or staging-test branch issues. I ended up commenting them and performing those steps manually. Learned a lot from the experience but not enough, yet :)

[sgould420]

This exercise should be removed from the learning path at https://learn.microsoft.com/en-us/training/modules/github-actions-cd/3-create-workflow-deploy-azure
until it is fixed.

[nicholasdagostino]

Hello,

I encountered an error on step 4,5,6 on this tutorial as well. When attempting to deploy to staging and production the npm install and build webpack step failed with this error:

[markpatterson27]

It's a known issue. Quick fix is to pin the node version on the runner to node v16. Add the following to the deploy-staging.yml and deploy-prod.yml workflows, just before the - name: npm install and build webpack step:

          - uses: actions/setup-node@v3
            with:
              node-version: 16

i.e.: skills/deploy-to-azure@d5ac4db in PR: skills/deploy-to-azure#40

Note: the tutorial was updated last month. The issues commented on at the start of this discussion thread are no longer relevant.

[nicholasdagostino]

yes it worked, this is what i added:

steps:
- uses: actions/checkout@v3

  - name: Setup Node.js environment
    uses: actions/setup-node@v2
    with:
      node-version: '16.x'

  - name: npm install and build webpack
    run: |
      npm install
      npm run build

  - uses: actions/upload-artifact@v3
    with:
      name: webpack artifacts
      path: public/