Generalizing and standardizing the deletion-from-collection algorithm

[stephengtuggy]

Hi guys,

I wanted to write some more tests of @BenjamenMeyer 's deletion-from-collection code. And also test a couple of other approaches, to see which one would be the best. You can see the results here:

stephengtuggy/raw_pointers_safe_deletion_tests#1

Feedback is welcome. Thanks!

[BenjamenMeyer]

I'm all for improving. Interesting that you were able to find a bug there too, but glad to see it fixed.

If we can support C++14 without issue that'd probably be good. ISO guidelines are now being written for C++20 or newer (annoying they don't keep a historic record but such is life).

[stephengtuggy]

Yep. Sounds good.

@royfalk what are your thoughts?