WiX Toolset
-
|
I am trying to build WiX using VS2022 17.0.2; I do not have previous VS versions installed on my development system. I have the appropriate workloads installed & added the V141&v142 c++ build tools for all 3 Using the head commit from the develop branch I receive the following warnings: But then receive an error of: I presume that this is an issue with the windows SDK (I have the default 19041 installed). Or do I need the ATL's for 141 & 142 installed? |
Beta Was this translation helpful? Give feedback.
Replies: 10 comments 22 replies
-
|
Others are better at diagnosing Windows SDK issues (and that looks like your problem) but I'd note that you'll want the very latest changes (as of this morning) to be able to successfully build using VS2022 (there are a few fixes). |
Beta Was this translation helpful? Give feedback.
-
|
@robmen Which version(s) of the Windows SDK do you have installed? (I am presuming that it is a Win 10 SDK since that is what VS2022 installs when you pick desktop C++ development) |
Beta Was this translation helpful? Give feedback.
-
|
@barnson and @rseanhall had "workload" definitions for VS2019 and one of them (I think Sean) tried to minimize his. Perhaps they can share and we can start on one for VS2022. |
Beta Was this translation helpful? Give feedback.
-
|
(For now. I'm testing whether we can get away with building only with v143.) |
Beta Was this translation helpful? Give feedback.
-
|
I have all three of the 141/142/143 build tools installed. I found the files; There are 3 copies in "c:\program files\microsoft visual studio\2022\community\vc\tools\XXXX\include" where XXX is 14.16.2703, 14.29.30133, 14.30.3075 Since the error is "C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\um\windows.h(167): fatal error C1083: Cannot open include file: 'excpt.h'" it appears that the issue is one of include paths. Do I need to set include paths? I am attempting the build from a VS2022 x86 command prompt. Is that not correct? |
Beta Was this translation helpful? Give feedback.
-
|
We are currently building with v140, 141 and 142. No, that is not correct. You should use the generic Developer Command Prompt for VS2022 (I hope that exists, it definitely did for VS2019). |
Beta Was this translation helpful? Give feedback.
-
|
Sorry, I have V140 build tools installed also; I tried the generic developer prompt with the same result. I was incorrectly interpreting the instruction from the V3 build document to start a 32 bit command prompt. |
Beta Was this translation helpful? Give feedback.
-
|
Here's my configuration for VS2022. I tried to install only things that were required for WiX. I went with the Windows 11 SDK since that's what is on the CI machines. This did require my changes here, but that probably could have been worked around by installing the .NET 4.0 targeting pack. |
Beta Was this translation helpful? Give feedback.
-
|
As of today (12/7) when I try to build with the head commit (after the @rseanhall PR was merged) I still get the errors attempting to include excpt.h However, if I check out the @barnson branch 'bob/vs2022' the build goes on for about 8 minutes, generates 17 nupkg's and 1 snupkg in artifacts. There were test errors of which is clearly an environment error, not a true test failure. And after figuring out how to install Notepad, the build runs to completion the following errors: |
Beta Was this translation helpful? Give feedback.
-
|
The build has state, and there is no official way to clean everything. It seems people are using git commands to do that, but you need to be careful that those only delete files you're comfortable with deleting. |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
Odd. Maybe the centralization of |
Beta Was this translation helpful? Give feedback.
-
|
Not really. With your branch, only the v143 toolset is required. This just confirms that something is wrong with the earlier toolsets on that machine. |
Beta Was this translation helpful? Give feedback.
-
|
Windows VS2022 17.0.2 @rseanhall All of the earlier toolsets were installed from the VS2022 installer |
Beta Was this translation helpful? Give feedback.
-
|
We discussed on wix-devs that we need to choose the lowest version of the toolset for libraries and the highest for linked code so the v143-only approach won't work. BTW, ARM isn't needed (though ARM64 is). |
Beta Was this translation helpful? Give feedback.
-
|
@barnson - I updated the comment above per your comment about ARM; I am presuming that the need for 141/142 will go away at some point. |
Beta Was this translation helpful? Give feedback.
-
|
I spent some extra time yesterday trying to clean my machine and minimize what VS2022 installed. I'm not really interested in spending any more time diagnosing this. It works everywhere else. I recommend uninstalling and then reinstalling VS2022 using the configuration I provided. |
Beta Was this translation helpful? Give feedback.
-
|
@rseanhall Thanks -- Unfortunately, I have no idea what to do with the list of components that you supplied. I am going to wait until v4 has some proper developer documentation before trying again, it is just too much an uphill battle to try to figure out a working dev environment in the current state, |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Sean, I actually figured out the procedure about an hour after I wrote my comment. Several of the components aren't available in VS2022 Community edition:
|
Beta Was this translation helpful? Give feedback.
-
|
Fortunately, you should not need those components to build the WiX Toolset. Hopefully, the rest of the missing Windows SDK bits will get turned on though so you can build native code. The error code about |
Beta Was this translation helpful? Give feedback.
-
|
I first just modified my VS2022 with the import file -- Same 4 errors with excpt.h I then totally removed VS2022 and reinstalled, again using the import file -- Same 4 errors... |
Beta Was this translation helpful? Give feedback.
-
|
Always with Community edition? It should work but I don't think anyone working on WiX v4 right now is using it. |
Beta Was this translation helpful? Give feedback.
-
|
Hmm. You should probably create a bug with Visual Studio. It looks like Appveyor's VS2022 image is using Community edition though, and it built fine there with the changes I recently pushed. |
Beta Was this translation helpful? Give feedback.
-
|
Oh yeah, I forgot about the CI build. |
Beta Was this translation helpful? Give feedback.
-
|
Two quick questions:
|
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
@rseanhall @barnson Thanks for the replies, that helps Bob, Couldn't you download the old VS CLI Tools 141 package (https://visualstudio.microsoft.com/vs/older-downloads/), put the installer image in the WiX4 repository, and then execute the installer as an early step in the build yaml? Not ideal, but it should work. [Edit] Arghh -- I decided to try this and the download is fine but it invokes the Visual Studio installer which certainly won't work in GitHub actions. Perhaps just adding the installed tools to the repository & updating a path variable? Now I know why you said that the problem wasn't solved :-) |
Beta Was this translation helpful? Give feedback.
-
|
Rob's experimenting with that in wixtoolset/wix#65. |
Beta Was this translation helpful? Give feedback.
-
|
Adds a chunk of time to the build, so haven't decided if we'll take the change like this now or not. I'd also like to see Bob's the |
Beta Was this translation helpful? Give feedback.
-
|
This was resolved with the build enhancements that support building with VS2022 |
Beta Was this translation helpful? Give feedback.
This was resolved with the build enhancements that support building with VS2022