From b3c6148d306d37f3add50b52f378ae258e65df88 Mon Sep 17 00:00:00 2001 From: Ingmar Splitt Date: Mon, 4 Dec 2023 19:03:08 +0100 Subject: [PATCH] small improvements to warning-system --- software/python-package/shepherd_sheep/h5_writer.py | 4 +++- software/python-package/shepherd_sheep/shared_memory.py | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/software/python-package/shepherd_sheep/h5_writer.py b/software/python-package/shepherd_sheep/h5_writer.py index 26678191..8bdd399a 100644 --- a/software/python-package/shepherd_sheep/h5_writer.py +++ b/software/python-package/shepherd_sheep/h5_writer.py @@ -234,13 +234,15 @@ def write_buffer(self, buffer: DataBuffer) -> None: ] = buffer.gpio_edges.values # noqa: PD011, false positive self.gpio_pos = gpio_new_pos - if (buffer.util_mean > 95) or (buffer.util_max > 100): + if (buffer.util_mean > 98) or (buffer.util_max > 100): self._logger.warning( "WARNING: timing critical, pru0 Loop-Util: mean = %d %%, max = %d %%", buffer.util_mean, buffer.util_max, ) # TODO: store pru-util? probably yes + # TODO: do not save continuous timestamps anymore + # but instead: buffer-timestamp, sample-count, pru-util mean & max def start_monitors( self, diff --git a/software/python-package/shepherd_sheep/shared_memory.py b/software/python-package/shepherd_sheep/shared_memory.py index 7a71995b..acce20c9 100644 --- a/software/python-package/shepherd_sheep/shared_memory.py +++ b/software/python-package/shepherd_sheep/shared_memory.py @@ -341,6 +341,7 @@ def read_buffer(self, index: int, verbose: bool = False) -> DataBuffer: pru0_util_mean, pru0_util_max, ) + # TODO: this is causing high overhead without a cape elif verbose: log.info( "Pru0 Loop-Util: mean = %d %%, max = %d %%",