Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogPlus 2.0 draft #150

Open
6 tasks
orhanobut opened this issue Apr 2, 2018 · 4 comments
Open
6 tasks

DialogPlus 2.0 draft #150

orhanobut opened this issue Apr 2, 2018 · 4 comments
Milestone

Comments

@orhanobut
Copy link
Owner

orhanobut commented Apr 2, 2018

Finally I have some time to improve this library. Since there was a huge break for this library, I'll collect major/minor issues under this one as tasks, the way I handled Hawk and Logger previously. I'll go through all open issues, but feel free to mention them.

  • Update all dependencies
  • Add support annotations, especially Nullable and NonNullable
  • Allow non-scrollable fixed header and footer
  • Provide an API to disable setting click listeners recursively.
  • Move content holder related methods to each holder
val dialog = DialogPlusBuilder()
    contentHolder = ListHolder.Builder(adapter)
         .setHeader(header, fixed)   // fixed -> boolean value to keep header at top
         .setFooter(footer, fixed)   // fixed -> boolean value to keep footer at bottom
         .setItemClickListener( dialog,item,view,position -> {
               // item
         })
}.build()
  • Provide RecyclerViewHolder
val dialog = DialogPlusBuilder()
    contentHolder = RecyclerViewHolder.Builder(adapter)
         .setLayoutManager(gridLayoutManager)  // optional, as default it'll be LinearLayoutManager
         .setHeader(header, fixed)   // fixed -> boolean value to keep header at top
         .setFooter(footer, fixed)   // fixed -> boolean value to keep footer at bottom
         .setItemClickListener( dialog,item,view,position -> {
               // item
         })
}.build()
@orhanobut orhanobut added this to the 2.0.0 milestone Apr 2, 2018
@Joslyn-Chen
Copy link

I am very supportive.

@HYTCTony
Copy link

How to use version 2.0?

1 similar comment
@EthanCo
Copy link

EthanCo commented Jan 25, 2019

How to use version 2.0?

@orhanobut orhanobut pinned this issue Mar 3, 2019
@Dboy233
Copy link

Dboy233 commented Jun 18, 2021

Hello

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants