Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new signature to the load_data method #294

Closed
JeanBilheux opened this issue Feb 28, 2024 · 1 comment
Closed

Add a new signature to the load_data method #294

JeanBilheux opened this issue Feb 28, 2024 · 1 comment
Assignees
@JeanBilheux

Comments

@JeanBilheux
Copy link
Contributor

It should also be possible to have the following signature:
sample is a folder
ob and dc are list of files
@JeanBilheux JeanBilheux self-assigned this Feb 28, 2024
JeanBilheux added a commit that referenced this issue Feb 29, 2024
@JeanBilheux
mix of dir and files allowed. this ref #294
321d1db
JeanBilheux added a commit that referenced this issue Mar 1, 2024
@JeanBilheux
fixed unit test. this refs #294
47e69a5
JeanBilheux added a commit that referenced this issue Mar 2, 2024
@JeanBilheux
removed uselss files. this refs #294
064267d
JeanBilheux added a commit that referenced this issue Mar 2, 2024
@JeanBilheux
Added unit test for new signature. this refs #294
bab5447
JeanBilheux added a commit that referenced this issue Mar 2, 2024
@JeanBilheux
removed useless files. this refs #294
dedfcae
JeanBilheux added a commit that referenced this issue Mar 2, 2024
@JeanBilheux
Fixed name of environment. this refs #294
a7bb37a
JeanBilheux added a commit that referenced this issue Mar 2, 2024
@JeanBilheux
Added part of code not covered yet. this refs #294
fc60d5a
JeanBilheux added a commit that referenced this issue Mar 2, 2024
@JeanBilheux
more unit test to cover untested part. this refs #294
84ac71b
JeanBilheux added a commit that referenced this issue Mar 2, 2024
@JeanBilheux
trying to cover line 165-165 in unit test. this refs #294
813571a
JeanBilheux added a commit that referenced this issue Mar 2, 2024
@JeanBilheux
trying to cover another part. this refs #294
938cdbc
JeanBilheux added a commit that referenced this issue Mar 2, 2024
@JeanBilheux
another try. this refs #294
1473926
KedoKudo added a commit that referenced this issue Mar 3, 2024
@KedoKudo
Merge pull request #296 from ornlneutronimaging/294_add_load_data_sig…
2fb979b 
…nature

mix of dir and files allowed. this ref #294
@KedoKudo
Copy link
Contributor

#296 has resolved this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeanBilheux JeanBilheux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeanBilheux @KedoKudo