Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Expand default command line interface #5

Open
suannchong opened this issue Apr 17, 2023 · 2 comments
Open

[Enhancement] Expand default command line interface #5

suannchong opened this issue Apr 17, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@suannchong
Copy link
Contributor

The instrument team would like additional command line features, including:

  • capability of switching between different clustering and centroiding method
  • capability of skipping clustering step (show raw hits only, no clustering)

Su-Ann's inputs:

  • capability to save hits and events h5 files for SophireadStream with filename prefix related to the raw tpx3 filename [Optional]

  • capability to set the DSCALE as an optional user input [Optional]

  • capability to find a trustworthy tdc to get a proper tof [Optional]

  • moved DAS computing equipment to H-304 to be connected to MCP/TPX3 detector. This way, we can ssh into the server and use the detector.

  • DAS will share their whole repository with me and you so we can look into some of the issues that they’re facing. Just a pair of extra eyes, not obligated to do anything. They believe that the rate limitation they experienced comes from a layer before doing tpx3 parsing.

  • Once the detector is set up on network, I will be working with the vendor to figure out the timestamp issues (whether or not we should update the firmware, etc)

  • We weren’t able to test sophiread as much as we want. Once the detector is set up as it was at SNAP, we can test our software to make sure the display and tof is fixed, as well as check if the rate limitation can be solved with SophireadStream and other memory leak issues or bugs from Rick's code.

  • We need to discuss with DAS about software refactorization with documentations. First, read the repo they going to share, understand the resources we need in terms of servers (host documents) and prepare a plan to discuss/convince DAS to software refactoring efforts.

@suannchong suannchong added the enhancement New feature or request label Apr 17, 2023
@KedoKudo
Copy link
Contributor

@suannchong I think we can close this issue with the CLI arugment parser class. Can you close this issue?

@KedoKudo
Copy link
Contributor

this seems relevant for allowing adjust frequency: 81e7bc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants