Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change AnalyserNode API, take mutable reference for time/freq data #254

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Change AnalyserNode API, take mutable reference for time/freq data #254

merged 1 commit into from
Jan 19, 2023

Conversation

orottier
Copy link
Owner

It requires some unsafe magic but it does make the API a lot nicer.
Fixes #253

@orottier
Change AnalyserNode API, take mutable reference for time/freq data
c0bfc66 
It requires some unsafe magic but it does make the API a lot nicer.
@orottier orottier requested a review from b-ma January 18, 2023 20:06
@github-actions
Copy link 

Benchmark result:


bench_ctor
  Instructions:             5124233 (-0.000137%)
  L1 Accesses:              8195410 (-0.000952%)
  L2 Accesses:                11514 (-0.052083%)
  RAM Accesses:               54564 (+0.014664%)
  Estimated Cycles:        10162720 (+0.001692%)

bench_sine
  Instructions:            80429095 (+0.000245%)
  L1 Accesses:            119092870 (-0.001836%)
  L2 Accesses:               235073 (+1.084493%)
  RAM Accesses:               56807 (+0.014085%)
  Estimated Cycles:       122256480 (+0.008756%)

bench_sine_gain
  Instructions:            85635891 (+0.000250%)
  L1 Accesses:            126972864 (-0.002630%)
  L2 Accesses:               250973 (+1.499195%)
  RAM Accesses:               56111 (+0.012477%)
  Estimated Cycles:       130191614 (+0.011861%)

bench_sine_gain_delay
  Instructions:           157893148 (+0.000157%)
  L1 Accesses:            226202771 (-0.008148%)
  L2 Accesses:               709864 (+2.729659%)
  RAM Accesses:               58204 (+0.006873%)
  Estimated Cycles:       231789231 (+0.032807%)

bench_buffer_src
  Instructions:            20509499 (+0.000809%)
  L1 Accesses:             31273174 (-0.000550%)
  L2 Accesses:                69993 (+0.670243%)
  RAM Accesses:               83913 (+0.017879%)
  Estimated Cycles:        34560094 (+0.007764%)

bench_buffer_src_delay
  Instructions:            93078113 (+0.000262%)
  L1 Accesses:            131508956 (+0.000119%)
  L2 Accesses:               168738 (+0.147784%)
  RAM Accesses:               84088 (+0.014273%)
  Estimated Cycles:       135295726 (+0.001347%)

bench_buffer_src_iir
  Instructions:            53884118 (+0.000399%)
  L1 Accesses:             76474733 (+0.000530%)
  L2 Accesses:                68713 (-0.072714%)
  RAM Accesses:               83858 (+0.011926%)
  Estimated Cycles:        79753328 (+0.000633%)

bench_buffer_src_biquad
  Instructions:            41646004 (+0.060212%)
  L1 Accesses:             60268955 (+0.085430%)
  L2 Accesses:               111441 (-0.455556%)
  RAM Accesses:               83928 (-0.004766%)
  Estimated Cycles:        63763640 (+0.076519%)

bench_stereo_positional
  Instructions:            50039123 (+0.000833%)
  L1 Accesses:             75612888 (+0.011591%)
  L2 Accesses:               796721 (-1.001023%)
  RAM Accesses:               84244 (+0.013059%)
  Estimated Cycles:        82545033 (-0.037701%)

bench_stereo_panning_automation
  Instructions:            33878164 (+0.000770%)
  L1 Accesses:             51806792 (-0.006447%)
  L2 Accesses:               150190 (+2.579689%)
  RAM Accesses:               83341 (+0.013201%)
  Estimated Cycles:        55474677 (+0.028724%)

@b-ma
Copy link
Collaborator

b-ma commented Jan 19, 2023

(whow unsafe code :)

Looks good to me! At least the API is consistent, whatever we do from that point

@orottier orottier merged commit c5294e2 into main Jan 19, 2023
@orottier orottier deleted the feature/analyser-node-mutable-slice branch June 2, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-ma b-ma Awaiting requested review from b-ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AnalyzerNode API
2 participants
@orottier @b-ma