Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review io::cpal/cubeb ThreadSafeClosableStream, probably not sound #357

Open
orottier opened this issue Aug 28, 2023 · 0 comments
Open

Review io::cpal/cubeb ThreadSafeClosableStream, probably not sound #357

orottier opened this issue Aug 28, 2023 · 0 comments

Comments

@orottier
Copy link
Owner

I doubt this construct is entirely safe. Stream is not Send/Sync (probably for a good reason) so
it should be managed from a single thread instead.
orottier added a commit that referenced this issue Aug 28, 2023
@orottier
Ignore clippy warning of Arc for non-Send type, add as TODO
504197a 
#357
@orottier orottier changed the title Review io::cpal ThreadSafeClosableStream, probably not sound Review io::cpal/cubeb ThreadSafeClosableStream, probably not sound Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orottier