-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The benchmarks tracking issue #458
Comments
This is confirmed with our criterion test runner:
|
Whow Cool! Do you confirm this is all on the same machine? |
I'm a bit confused with how the "faster?" is actually computed e.g. for granular numbers look like twice faster (so 200% in my head) but the column report 48%... I can imagine there is some underlying factor of 2 but which one? |
Huh very good point. My brain bricked for a second. In my table, 'faster' is good old In any case, it's not the most important. I only wanted to check if we somehow regressed anywhere. I will now focus on the comparison to the web browsers to answer the question |
Yes. Only a more recent rust compiler - which of course could also be a fair gain |
@b-ma How did you run the Spotify suite again? |
I had to modify the source code a bit to make it work, my fork is there: https://github.com/b-ma/web-audio-bench (as the original repo is archived, this is really ok I think) I just cleaned a bit and introduced some command line options, let me know if something is not clear in the README |
With #470 audio param optimizations things are looking nice. We're only the slowest implementation now for 'mixing' and 'convolution'. |
Cool! |
Convolution performance has greatly improved after #537 |
We have currently benchmarked our implementation against two well know suites:
Results of the padenot suite
Some quick and dirty results from the Spotify suite:
These benchmark have been run beginning of March 2023, I guess on revision 3b26ae6
main
to see where we have progressed and regressed (spoiler alert: probably a regression in panning now we support stereo properly).The text was updated successfully, but these errors were encountered: