AudioBufferSourceNode: inconsistencies in fast and slow track #527
Conversation
|
Right, I understand. Let me know if I can help somehow! |
|
Ok, I think the failing test was faulty actually, I renamed it to I left a bunch of todos I will try to tackle in the next days Edit: also tested against wpt, no regression there |
src/node/audio_buffer_source.rs
Outdated
| // Thus it violates the rule defined in | ||
| // https://webaudio.github.io/web-audio-api/#playback-AudioBufferSourceNode | ||
| // `loopStart >= 0 && loopEnd > 0 && loopStart < loopEnd` | ||
| // Hence the whole buffer should be looped |
There was a problem hiding this comment.
Yes, I agree. I did not put too much thought into the expected result earlier, just focused on fixing the indefinite loop. Thanks!
|
Alright nice going! |
|
Ok I think it's all good to me for this one |
|
/bench |
|
Benchmarks are currently failing #529 |
|
Okay maybe we don't have benchmarks for slow-track processing anyway.. oh well |
Work in progress for #525
The failing tests are passing now but it introduced / revealed another issue,
test_loop_hangsis now failing for another reason....The semantics of loop start and end are not clear and they are thus not applied properly in edge cases I think, I need / will take some time to review all this properly