Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support hooks #666

Open
4 of 5 tasks
till opened this issue Feb 6, 2024 · 3 comments
Open
4 of 5 tasks

support hooks #666

till opened this issue Feb 6, 2024 · 3 comments
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.

Comments

@till
Copy link
Contributor

till commented Feb 6, 2024

Preflight checklist

Ory Network Project

No response

Describe your problem

Trying to figure out how to add hook files to the container.

The examples to use the kratos hooks usually look like this:

selfservice:
  flows:
    settings:
      after:
        profile:
          hooks:
            - hook: web_hook
              config:
                url: http://service
                method: POST
                body: file:///path/to/<something>.jsonnet
                can_interrupt: true

So this means /path/to/<something>.jsonnet has to be included or mounted into the container.

Describe your ideal solution

Ideally, the values would support this — similar to the schema files.

Workarounds or alternatives

Wrap the helm chart into another one, or prepend a helm chart (or manifests) to create k8s configs which I can then mount via extra volumes? I would rather maintain this in this helm chart instead of writing more helm.

Version

latest

Additional Context

No response

@till till added the feat New feature or request. label Feb 6, 2024
@Demonsthere
Copy link
Collaborator

Hello there!
The current solution would be to supply the jsonnet files as extra config maps and mount into the containers using:

  extraVolumes: []
  # - name: my-volume
  #   secret:
  #     secretName: my-secret
  extraVolumeMounts: []
  # - name: my-volume
  #   mountPath: /etc/secrets/my-secret
  #   readOnly: true

We could add an option to add arbitrary data to a CM to make it easier and nor requite to sideload the config 🤔

@till
Copy link
Contributor Author

till commented Feb 16, 2024

@Demonsthere You mean, currently I'd have to build the ConfigMap myself, right?

I think a general mechanism for the hooks would be great.

Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

2 participants