-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for B2B SSO #3489
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3489 +/- ##
==========================================
- Coverage 78.34% 78.19% -0.15%
==========================================
Files 341 341
Lines 22691 22754 +63
==========================================
+ Hits 17777 17793 +16
- Misses 3586 3623 +37
- Partials 1328 1338 +10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I think the dependency injection is overengineered. I would recommend either implementing a Set
function or making the member public.
Co-authored-by: hackerman <[email protected]>
9b466ad
to
2579ab2
Compare
Signed-off-by: Henning Perl <[email protected]>
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments