Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for B2B SSO #3489

Merged
merged 15 commits into from
Sep 21, 2023
Merged

feat: support for B2B SSO #3489

merged 15 commits into from
Sep 21, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Sep 11, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl self-assigned this Sep 11, 2023
@hperl hperl marked this pull request as ready for review September 18, 2023 18:10
@hperl hperl requested review from alnr and jonas-jonas September 18, 2023 18:10
@hperl hperl changed the title WIP: B2B SSO organization support feat: B2B SSO organization support Sep 18, 2023
@hperl hperl changed the title feat: B2B SSO organization support feat: support for B2B SSO Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #3489 (c737c40) into master (4c34c24) will decrease coverage by 0.15%.
Report is 1 commits behind head on master.
The diff coverage is 60.33%.

❗ Current head c737c40 differs from pull request most recent head 06c879f. Consider uploading reports for the commit 06c879f to get more accurate results

@@            Coverage Diff             @@
##           master    #3489      +/-   ##
==========================================
- Coverage   78.34%   78.19%   -0.15%     
==========================================
  Files         341      341              
  Lines       22691    22754      +63     
==========================================
+ Hits        17777    17793      +16     
- Misses       3586     3623      +37     
- Partials     1328     1338      +10     
Files Changed Coverage Δ
driver/registry.go 34.21% <0.00%> (-6.42%) ⬇️
selfservice/flow/login/flow.go 97.70% <ø> (ø)
selfservice/flow/login/strategy.go 80.00% <ø> (ø)
selfservice/flow/registration/flow.go 100.00% <ø> (ø)
selfservice/flow/registration/strategy.go 80.00% <ø> (ø)
selfservice/strategy/oidc/provider_apple.go 37.93% <ø> (ø)
selfservice/strategy/oidc/provider_auth0.go 72.30% <ø> (ø)
selfservice/strategy/oidc/provider_dingtalk.go 31.52% <ø> (ø)
selfservice/strategy/oidc/provider_discord.go 0.00% <ø> (ø)
selfservice/strategy/oidc/provider_facebook.go 83.56% <ø> (ø)
... and 33 more

... and 1 file with indirect coverage changes

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I think the dependency injection is overengineered. I would recommend either implementing a Set function or making the member public.

.schemastore/config.schema.json Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
driver/registry_default.go Outdated Show resolved Hide resolved
driver/registry_default.go Outdated Show resolved Hide resolved
driver/registry_default_hooks.go Outdated Show resolved Hide resolved
selfservice/flow/login/handler.go Show resolved Hide resolved
selfservice/flow/registration/handler.go Show resolved Hide resolved
selfservice/strategy/oidc/provider_config.go Show resolved Hide resolved
selfservice/strategy/oidc/strategy.go Outdated Show resolved Hide resolved
session/session.go Show resolved Hide resolved
@hperl hperl force-pushed the hperl/b2bsso branch 2 times, most recently from 9b466ad to 2579ab2 Compare September 19, 2023 09:16
@hperl hperl requested a review from aeneasr September 19, 2023 11:50
@aeneasr aeneasr merged commit 0ec037a into master Sep 21, 2023
26 checks passed
@aeneasr aeneasr deleted the hperl/b2bsso branch September 21, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants